Re: Fix thinko in var-tracking.c

2011-05-09 Thread Mike Stump
On May 9, 2011, at 6:05 AM, Joseph S. Myers wrote: > The guality tests have random results. I don't know if that's the issue > here, but perhaps someone can review Jeff's patch > to make them > more predictable. Without that, I generall

Re: Fix thinko in var-tracking.c

2011-05-09 Thread Joseph S. Myers
On Mon, 9 May 2011, Eric Botcazou wrote: > doesn't affect code generation, I think it's appropriate for all branches. > It > seems to introduce a couple of XPASSes in the guality testsuite on i586: > > XPASS: gcc.dg/guality/inline-params.c -O2 -flto execution test > XPASS: gcc.dg/guality/pr4

Fix thinko in var-tracking.c

2011-05-09 Thread Eric Botcazou
There is a known pitfall with REG_OFFSET/MEM_OFFSET: the former is an integer whereas the latter is a RTX. So a test like MEM_OFFSET (node->loc) == 0 is essentially never true for user MEMs since you have const0_rtx instead. The attached patch fixes 3 occurrences introduced in the VTA merge; si