Re: Fix thinko in gimple_assign_set_rhs_with_ops

2017-07-28 Thread Eric Botcazou
> I think we should get rid of that update-EH-info flag, always assuming > false. This is IMHO a too low-level interface to do this (and we lack a > gsi_replace_without_update) This looks doable (there is only one call to gsi_replace that tests the return value) but the current interface is prob

Re: Fix thinko in gimple_assign_set_rhs_with_ops

2017-07-26 Thread Richard Biener
On Tue, Jul 25, 2017 at 3:59 PM, Eric Botcazou wrote: > The attached fix to the Ada front-end introduces a regression in the ACATS > testsuite for cb4009a. The backtrace is: > > #0 operation_could_trap_helper_p(tree_code, bool, bool, bool, bool, > tree_node*, bool*) () at /home/eric/gnat/gnat-he

Fix thinko in gimple_assign_set_rhs_with_ops

2017-07-25 Thread Eric Botcazou
The attached fix to the Ada front-end introduces a regression in the ACATS testsuite for cb4009a. The backtrace is: #0 operation_could_trap_helper_p(tree_code, bool, bool, bool, bool, tree_node*, bool*) () at /home/eric/gnat/gnat-head/src/gcc/tree-eh.c:2439 #1 0x012946d7 in stmt_could