Re: Fix profile updating in ifcombine

2017-02-07 Thread Richard Earnshaw (lists)
On 07/02/17 08:37, Christophe Lyon wrote: > Hi, > > > On 6 February 2017 at 17:56, Richard Earnshaw (lists) > wrote: >> On 06/02/17 15:54, Jiong Wang wrote: >>> On 06/02/17 15:26, Jan Hubicka wrote: I think it is not a regression, just the testcase if fragile and depends on outcome >>>

Re: Fix profile updating in ifcombine

2017-02-07 Thread Christophe Lyon
Hi, On 6 February 2017 at 17:56, Richard Earnshaw (lists) wrote: > On 06/02/17 15:54, Jiong Wang wrote: >> On 06/02/17 15:26, Jan Hubicka wrote: >>> I think it is not a regression, just the testcase if fragile and >>> depends on outcome >>> of ifcombine. It seems it was updated several time in

Re: Fix profile updating in ifcombine

2017-02-06 Thread Richard Earnshaw (lists)
On 06/02/17 15:54, Jiong Wang wrote: > On 06/02/17 15:26, Jan Hubicka wrote: >> I think it is not a regression, just the testcase if fragile and >> depends on outcome >> of ifcombine. It seems it was updated several time in the past. I am >> not quite >> sure what the test is testing. > > They ar

Re: Fix profile updating in ifcombine

2017-02-06 Thread Jiong Wang
On 06/02/17 15:26, Jan Hubicka wrote: I think it is not a regression, just the testcase if fragile and depends on outcome of ifcombine. It seems it was updated several time in the past. I am not quite sure what the test is testing. They are tring to make sure optimal stack adjustment decision

Re: Fix profile updating in ifcombine

2017-02-06 Thread Jan Hubicka
> > After this patch (r245151), I've noticed regressions on aarch64: > gcc.target/aarch64/test_frame_1.c scan-assembler-times ldr\tx30, > \\[sp\\], [0-9]+ 2 > gcc.target/aarch64/test_frame_2.c scan-assembler-times ldp\tx19, > x30, \\[sp\\], [0-9]+ 1 > gcc.target/aarch64/test_frame_4.c scan-a

Re: Fix profile updating in ifcombine

2017-02-06 Thread Christophe Lyon
Hi, On 3 February 2017 at 08:56, Jeff Law wrote: > On 02/02/2017 01:29 PM, Jan Hubicka wrote: >> >> Hi, >> this patches fixes profile updating in the ifcombine. This is not hard to >> do >> and ifcombine is #2 profile update offender out of tree passes (#1 is the >> vectorizer). >> >> I think t

Re: Fix profile updating in ifcombine

2017-02-02 Thread Jeff Law
On 02/02/2017 01:29 PM, Jan Hubicka wrote: Hi, this patches fixes profile updating in the ifcombine. This is not hard to do and ifcombine is #2 profile update offender out of tree passes (#1 is the vectorizer). I think this counts as a regression, becuase one can trigger arbitrarily bad profile

Re: Fix profile updating in ifcombine

2017-02-02 Thread Andrew Pinski
On Thu, Feb 2, 2017 at 12:29 PM, Jan Hubicka wrote: > Hi, > this patches fixes profile updating in the ifcombine. This is not hard to do > and ifcombine is #2 profile update offender out of tree passes (#1 is the > vectorizer). > > I think this counts as a regression, becuase one can trigger arbi

Fix profile updating in ifcombine

2017-02-02 Thread Jan Hubicka
Hi, this patches fixes profile updating in the ifcombine. This is not hard to do and ifcombine is #2 profile update offender out of tree passes (#1 is the vectorizer). I think this counts as a regression, becuase one can trigger arbitrarily bad profile after ifconversion and defnitly construct a