Re: Fix partitioning ICE with external comdats

2019-12-17 Thread Andreas Schwab
On Dez 17 2019, Jan Hubicka wrote: > Index: symtab.c > === > --- symtab.c (revision 279178) > +++ symtab.c (working copy) > @@ -1952,6 +1952,11 @@ symtab_node::get_partitioning_class (voi >if (DECL_EXTERNAL (decl)) > return

Fix partitioning ICE with external comdats

2019-12-17 Thread Jan Hubicka
Hi, while hacking firefox to work around ABI compatibility issues with LLVM I ran into an ICE where comdat group was resolved externaly but contains a static alias (for thunk). In this case parittioner attempts to put that static definition into a partition which triggers an ICE. Bootstrapped/regt