Re: Fix partitioning ICE with external comdats

2019-12-17 Thread Andreas Schwab
On Dez 17 2019, Jan Hubicka wrote: > Index: symtab.c > === > --- symtab.c (revision 279178) > +++ symtab.c (working copy) > @@ -1952,6 +1952,11 @@ symtab_node::get_partitioning_class (voi >if (DECL_EXTERNAL (decl)) > return

Fix partitioning ICE with external comdats

2019-12-17 Thread Jan Hubicka
Hi, while hacking firefox to work around ABI compatibility issues with LLVM I ran into an ICE where comdat group was resolved externaly but contains a static alias (for thunk). In this case parittioner attempts to put that static definition into a partition which triggers an ICE. Bootstrapped/regt

Fix partitioning ICE

2018-05-15 Thread Jan Hubicka
Hi, this patch silences sanity check that makes sure that everything is in partition 0 and thus boundary cost is 0 when there is only one partition. In the testcase there is external initializer which does not get partitioned and thus we end up with cost 1. Fixed by not accounting references from