Re: Fix hanlding of gimple_clobber in ICF

2020-11-24 Thread Jan Hubicka
> Hi Honza! > > On 2020-11-19T13:33:53+0100, Jan Hubicka wrote: > > --- a/gcc/ipa-icf-gimple.c > > +++ b/gcc/ipa-icf-gimple.c > > @@ -245,6 +245,14 @@ func_checker::hash_operand (const_tree arg, > > inchash::hash &hstate, > >break; > > } > > > > + /* In gimple all clobbers can be c

Re: Fix hanlding of gimple_clobber in ICF

2020-11-24 Thread Thomas Schwinge
Hi Honza! On 2020-11-19T13:33:53+0100, Jan Hubicka wrote: > --- a/gcc/ipa-icf-gimple.c > +++ b/gcc/ipa-icf-gimple.c > @@ -245,6 +245,14 @@ func_checker::hash_operand (const_tree arg, > inchash::hash &hstate, >break; > } > > + /* In gimple all clobbers can be considered equal: while

Re: Fix hanlding of gimple_clobber in ICF

2020-11-19 Thread Richard Biener
On Thu, 19 Nov 2020, Jan Hubicka wrote: > Hi, > after fixing few issues I gotto stage where 1.4M icf mismatches are due to > comparing two gimple clobber. The problem is that operand_equal_p match > clobber > > case CONSTRUCTOR: > /* In GIMPLE empty constructors are allowed in initializers of

Fix hanlding of gimple_clobber in ICF

2020-11-19 Thread Jan Hubicka
Hi, after fixing few issues I gotto stage where 1.4M icf mismatches are due to comparing two gimple clobber. The problem is that operand_equal_p match clobber case CONSTRUCTOR: /* In GIMPLE empty constructors are allowed in initializers of aggregates. */ return !CONSTRUCTOR_NELTS (arg0) &