Re: Fix crossmodule ipa-inline hint

2019-12-02 Thread Jakub Jelinek
On Sun, Dec 01, 2019 at 03:44:38PM +0100, Jan Hubicka wrote: > > On Nov 30 2019, Jan Hubicka wrote: > > > > > * g++.dg/lto/inline-crossmodule-1.h: New testcase. > > > * g++.dg/lto/inline-crossmodule-1_0.C: New testcase. > > > * g++.dg/lto/inline-crossmodule-1_1.C: New testcase. > > > > ERRO

Re: Fix crossmodule ipa-inline hint

2019-12-01 Thread Jan Hubicka
> On Nov 30 2019, Jan Hubicka wrote: > > > * g++.dg/lto/inline-crossmodule-1.h: New testcase. > > * g++.dg/lto/inline-crossmodule-1_0.C: New testcase. > > * g++.dg/lto/inline-crossmodule-1_1.C: New testcase. > > ERROR: (DejaGnu) proc "scan-wpa-ipa-times {Inlined ret1} 1 inlined" does

Re: Fix crossmodule ipa-inline hint

2019-12-01 Thread Andreas Schwab
On Nov 30 2019, Jan Hubicka wrote: > * g++.dg/lto/inline-crossmodule-1.h: New testcase. > * g++.dg/lto/inline-crossmodule-1_0.C: New testcase. > * g++.dg/lto/inline-crossmodule-1_1.C: New testcase. ERROR: (DejaGnu) proc "scan-wpa-ipa-times {Inlined ret1} 1 inlined" does not exi

Fix crossmodule ipa-inline hint

2019-11-30 Thread Jan Hubicka
Hi, while looking into Firefox perofmrance I noticed that inline hint marking crossmodule calls is off most of time. It is based on comparing lto_file_data which is often released because ipa-icf or profile merging has read the function body before inlining. Moreover this logic is broken for incr