Re: Fix can_inline_edge_p and code marking calls unreachable

2015-03-27 Thread Christophe Lyon
On 27 March 2015 at 03:14, Jan Hubicka wrote: >> On 2015.03.27 at 00:46 +0100, Jan Hubicka wrote: >> > > On 26 March 2015 at 22:12, Jan Hubicka wrote: >> > > After this fix, I can see build failures in glibc: >> > > key_call.c:574:1: internal compiler error: in inline_call, at >> > > ipa-inline-t

Re: Fix can_inline_edge_p and code marking calls unreachable

2015-03-26 Thread Jan Hubicka
> On 2015.03.27 at 00:46 +0100, Jan Hubicka wrote: > > > On 26 March 2015 at 22:12, Jan Hubicka wrote: > > > After this fix, I can see build failures in glibc: > > > key_call.c:574:1: internal compiler error: in inline_call, at > > > ipa-inline-transform.c:386 > > > > Can you please send me prepr

Re: Fix can_inline_edge_p and code marking calls unreachable

2015-03-26 Thread Markus Trippelsdorf
On 2015.03.27 at 00:46 +0100, Jan Hubicka wrote: > > On 26 March 2015 at 22:12, Jan Hubicka wrote: > > After this fix, I can see build failures in glibc: > > key_call.c:574:1: internal compiler error: in inline_call, at > > ipa-inline-transform.c:386 > > Can you please send me preprocessed testca

Re: Fix can_inline_edge_p and code marking calls unreachable

2015-03-26 Thread Jan Hubicka
Hi, I reproduced the problem of Firefox LTO (though small testcase would be welcome) The problem is in a way we walk edges that now can be turned from indirect to direct. I am working on a fix. Honza

Re: Fix can_inline_edge_p and code marking calls unreachable

2015-03-26 Thread Jan Hubicka
> On 26 March 2015 at 22:12, Jan Hubicka wrote: > > Hi, > > this patch missed hunk adding CIF code that I commited now > > * cif-code.def (CILK_SPAWN): New code > > Hi, > After this fix, I can see build failures in glibc: > key_call.c:574:1: internal compiler error: in inline_call, at > i

Re: Fix can_inline_edge_p and code marking calls unreachable

2015-03-26 Thread Christophe Lyon
On 26 March 2015 at 22:12, Jan Hubicka wrote: > Hi, > this patch missed hunk adding CIF code that I commited now > * cif-code.def (CILK_SPAWN): New code Hi, After this fix, I can see build failures in glibc: key_call.c:574:1: internal compiler error: in inline_call, at ipa-inline-transfor

Re: Fix can_inline_edge_p and code marking calls unreachable

2015-03-26 Thread Jan Hubicka
Hi, this patch missed hunk adding CIF code that I commited now * cif-code.def (CILK_SPAWN): New code. --- trunk/gcc/cif-code.def 2015/03/26 20:37:53 221709 +++ trunk/gcc/cif-code.def 2015/03/26 21:10:28 221710 @@ -124,6 +124,10 @@ DEFCIFCODE(ATTRIBUTE_MISMATCH, CIF_FINAL

Fix can_inline_edge_p and code marking calls unreachable

2015-03-26 Thread Jan Hubicka
Hi, this patch fixes several issues in the inliner. First is the fact that edge_set_predicate does not mark indirect and speculative edge as unreachable correctly (found by my updated verification patch). Other issue is that can_inline_edge_p was wrong in several ways. It did use DECL_STRUCT_FUNC