Re: Fix PR66206

2015-12-21 Thread Jeff Law
On 12/17/2015 06:00 PM, Bernd Schmidt wrote: This is a small problem found by a static analyzer, a function in bt-load can in theory return the address of a local variable. Bootstrapped and tested on x86_64-linux, ok? OK. jeff

Re: Fix PR66206

2015-12-19 Thread Eric Botcazou
> This is a small problem found by a static analyzer, a function in > bt-load can in theory return the address of a local variable. > > Bootstrapped and tested on x86_64-linux, ok? OK, thanks. -- Eric Botcazou

Re: Fix PR66206

2015-12-17 Thread Bernd Schmidt
On 12/18/2015 02:15 AM, Andrew Pinski wrote: Except PATTERN (insn) will never be a REG. The only case where the input can be a REG is: gcc_assert (!find_btr_use (src)); Yeah, so we _are_ calling it with a REG. It's a minor issue that won't trigger in practice, but in order to close the PR we

Re: Fix PR66206

2015-12-17 Thread Andrew Pinski
On Thu, Dec 17, 2015 at 5:00 PM, Bernd Schmidt wrote: > This is a small problem found by a static analyzer, a function in bt-load > can in theory return the address of a local variable. > > Bootstrapped and tested on x86_64-linux, ok? Except PATTERN (insn) will never be a REG. The only case where

Fix PR66206

2015-12-17 Thread Bernd Schmidt
This is a small problem found by a static analyzer, a function in bt-load can in theory return the address of a local variable. Bootstrapped and tested on x86_64-linux, ok? Bernd PR rtl-optimization/66206 * bt-load.c (find_btr_use): Change first arg to be a pointer to an rtx. All callers ch