Re: Fix PR53908

2012-07-16 Thread Richard Guenther
On Fri, Jul 13, 2012 at 11:49 PM, Steven Bosscher wrote: > On Fri, Jul 13, 2012 at 10:56 AM, Hans-Peter Nilsson > wrote: >>> From: Richard Guenther >>> Date: Fri, 13 Jul 2012 10:08:05 +0200 >>> On Fri, Jul 13, 2012 at 9:59 AM, Hans-Peter Nilsson >>> wrote: >>> > Ok for 4.7 too? >>> >>> Of cours

Re: Fix PR53908

2012-07-13 Thread Steven Bosscher
On Fri, Jul 13, 2012 at 10:56 AM, Hans-Peter Nilsson wrote: >> From: Richard Guenther >> Date: Fri, 13 Jul 2012 10:08:05 +0200 >> On Fri, Jul 13, 2012 at 9:59 AM, Hans-Peter Nilsson >> wrote: >> > Ok for 4.7 too? >> >> Of course. > > Committed to trunk as follows, including the test-case which >

Re: Fix PR53908

2012-07-13 Thread Hans-Peter Nilsson
> From: Richard Guenther > Date: Fri, 13 Jul 2012 10:08:05 +0200 > On Fri, Jul 13, 2012 at 9:59 AM, Hans-Peter Nilsson > wrote: > > Ok for 4.7 too? > > Of course. Committed to trunk as follows, including the test-case which doesn't fail on trunk but does on 4.6 and 4.7. Will commit to 4.7 bran

Re: Fix PR53908

2012-07-13 Thread Richard Guenther
On Fri, Jul 13, 2012 at 9:59 AM, Hans-Peter Nilsson wrote: >> From: Richard Guenther >> Date: Fri, 13 Jul 2012 09:37:13 +0200 > >> On Fri, Jul 13, 2012 at 9:21 AM, Steven Bosscher >> wrote: >> > On Fri, Jul 13, 2012 at 8:47 AM, Hans-Peter Nilsson >> > wrote: >> >>> From: Richard Sandiford >>

Re: Fix PR53908

2012-07-13 Thread Hans-Peter Nilsson
> From: Richard Guenther > Date: Fri, 13 Jul 2012 09:37:13 +0200 > On Fri, Jul 13, 2012 at 9:21 AM, Steven Bosscher > wrote: > > On Fri, Jul 13, 2012 at 8:47 AM, Hans-Peter Nilsson > > wrote: > >>> From: Richard Sandiford > >>> Date: Thu, 12 Jul 2012 21:18:54 +0200 > >>> OK with that change i

Re: Fix PR53908

2012-07-13 Thread Richard Guenther
On Fri, Jul 13, 2012 at 9:21 AM, Steven Bosscher wrote: > On Fri, Jul 13, 2012 at 8:47 AM, Hans-Peter Nilsson > wrote: >>> From: Richard Sandiford >>> Date: Thu, 12 Jul 2012 21:18:54 +0200 >> >>> if (CALL_P (insn)) >>> { >>> if (RTL_CONST_OR_PURE_CALL_P (insn)) >>>

Re: Fix PR53908

2012-07-13 Thread Steven Bosscher
On Fri, Jul 13, 2012 at 8:47 AM, Hans-Peter Nilsson wrote: >> From: Richard Sandiford >> Date: Thu, 12 Jul 2012 21:18:54 +0200 > >> if (CALL_P (insn)) >> { >> if (RTL_CONST_OR_PURE_CALL_P (insn)) >> /* Pure functions can read from memory. Const functions can >>

Re: Fix PR53908

2012-07-12 Thread Hans-Peter Nilsson
> From: Richard Sandiford > Date: Thu, 12 Jul 2012 21:18:54 +0200 > if (CALL_P (insn)) > { > if (RTL_CONST_OR_PURE_CALL_P (insn)) > /* Pure functions can read from memory. Const functions can > read from arguments that the ABI has forced onto the stack.

Re: Fix PR53908

2012-07-12 Thread Richard Sandiford
Steven Bosscher writes: > On Wed, Jul 11, 2012 at 1:24 PM, Bernd Schmidt > wrote>> We're moving a load across a call since we don't recognize calls as >> memory-clobbering. >> >> Bootstrapping and testing now on 4.7 x86_64-linux, ok everywhere? > > Maybe: > + if (CALL_P (insn) > + &

Re: Fix PR53908

2012-07-11 Thread Steven Bosscher
On Wed, Jul 11, 2012 at 1:24 PM, Bernd Schmidt wrote: > We're moving a load across a call since we don't recognize calls as > memory-clobbering. > > Bootstrapping and testing now on 4.7 x86_64-linux, ok everywhere? Maybe: + if (CALL_P (insn) + && ! RTL_CONST_OR_PURE_CALL_P (insn)) ?

Fix PR53908

2012-07-11 Thread Bernd Schmidt
We're moving a load across a call since we don't recognize calls as memory-clobbering. Bootstrapping and testing now on 4.7 x86_64-linux, ok everywhere? Bernd PR rtl-optimization/53908 * df-problems.c (can_move_insns_across): Calls can clobber memory. Index: gcc/df-problems.c