Re: rfa: remove get_var_ann (was: Fix PR50260)

2011-10-06 Thread Richard Guenther
On Thu, Oct 6, 2011 at 4:59 PM, Michael Matz wrote: > Hi, > > On Sat, 3 Sep 2011, Richard Guenther wrote: > >> > OTOH it's a nice invariant that can actually be checked for (that all >> > reachable vars whatsoever have to be in referenced_vars), so I'm going >> > to do that. >> >> Yes, until we ge

Re: rfa: remove get_var_ann (was: Fix PR50260)

2011-10-06 Thread Michael Matz
Hi, On Sat, 3 Sep 2011, Richard Guenther wrote: > > OTOH it's a nice invariant that can actually be checked for (that all > > reachable vars whatsoever have to be in referenced_vars), so I'm going > > to do that. > > Yes, until we get rid of referenced_vars (which we still should do at > some

Re: rfa: remove get_var_ann (was: Fix PR50260)

2011-09-03 Thread Richard Guenther
On Sat, Sep 3, 2011 at 5:31 PM, Michael Matz wrote: > Hi, > > On Sat, 3 Sep 2011, Richard Guenther wrote: > >> >> As I feared the call to get_var_ann in set_is_used right now really >> >> is still needed, privatizing it hence isn't that straight forward. >> > >> > After pondering I concluded that

Re: rfa: remove get_var_ann (was: Fix PR50260)

2011-09-03 Thread Michael Matz
Hi, On Sat, 3 Sep 2011, Richard Guenther wrote: > >> As I feared the call to get_var_ann in set_is_used right now really > >> is still needed, privatizing it hence isn't that straight forward. > > > > After pondering I concluded that it's not necessary to call > > set_is_used for variables with

Re: rfa: remove get_var_ann (was: Fix PR50260)

2011-09-03 Thread Richard Guenther
On Sat, Sep 3, 2011 at 3:51 AM, Michael Matz wrote: > Hi, > > On Fri, 2 Sep 2011, Michael Matz wrote: > >> > > Ok.  Time to make get_var_ann private? >> >> As I feared the call to get_var_ann in set_is_used right now really is >> still needed, privatizing it hence isn't that straight forward. > >

Re: Fix PR50260

2011-09-03 Thread Richard Guenther
On Fri, Sep 2, 2011 at 8:40 PM, Michael Matz wrote: > Hi, > > On Fri, 2 Sep 2011, Michael Matz wrote: > >> Hi, >> >> On Fri, 2 Sep 2011, Richard Guenther wrote: >> >> > > Currently regstrapping on x86_64-linux (without Ada).  Okay for trunk? >> > >> > Ok.  Time to make get_var_ann private? >> >> Y

rfa: remove get_var_ann (was: Fix PR50260)

2011-09-02 Thread Michael Matz
Hi, On Fri, 2 Sep 2011, Michael Matz wrote: > > > Ok. Time to make get_var_ann private? > > As I feared the call to get_var_ann in set_is_used right now really is > still needed, privatizing it hence isn't that straight forward. After pondering I concluded that it's not necessary to call set_

Re: Fix PR50260

2011-09-02 Thread Michael Matz
Hi, On Fri, 2 Sep 2011, Michael Matz wrote: > Hi, > > On Fri, 2 Sep 2011, Richard Guenther wrote: > > > > Currently regstrapping on x86_64-linux (without Ada).  Okay for trunk? > > > > Ok. Time to make get_var_ann private? > > Yes. Should the regstrap succeed on x86_64-linux I'll commit thi

Re: Fix PR50260

2011-09-02 Thread Michael Matz
Hi, On Fri, 2 Sep 2011, Richard Guenther wrote: > > Currently regstrapping on x86_64-linux (without Ada).  Okay for trunk? > > Ok. Time to make get_var_ann private? Yes. Should the regstrap succeed on x86_64-linux I'll commit this variant of the patch (hunks in tree-flow.h, tree-flow-inline.

Re: Fix PR50260

2011-09-02 Thread Richard Guenther
On Thu, Sep 1, 2011 at 2:41 PM, Michael Matz wrote: > Hi, > > the last change in ipa-split generated a new use of a previously unused > PARM_DECL.  When one does this one has to call add_referenced_var.  Not > doing so can cause segfault when accessing the (not initialized) var > annotation.  So,

Re: Fix PR50260

2011-09-01 Thread Martin Jambor
Hi, On Thu, Sep 01, 2011 at 02:41:15PM +0200, Michael Matz wrote: > Hi, > > the last change in ipa-split generated a new use of a previously unused > PARM_DECL. When one does this one has to call add_referenced_var. Not > doing so can cause segfault when accessing the (not initialized) var >

Fix PR50260

2011-09-01 Thread Michael Matz
Hi, the last change in ipa-split generated a new use of a previously unused PARM_DECL. When one does this one has to call add_referenced_var. Not doing so can cause segfault when accessing the (not initialized) var annotation. So, fixed with the patch. I took the opportunity to remove all e