Re: Fix ICE with -fauto-profile when walking vdefs

2017-04-19 Thread Richard Biener
On April 19, 2017 12:55:24 PM GMT+02:00, "Martin Liška" wrote: >On 04/18/2017 08:05 PM, Sebastian Pop wrote: >> On Mon, Apr 3, 2017 at 5:34 AM, Richard Biener >wrote: >>> On Fri, 31 Mar 2017, Sebastian Pop wrote: >>> On Fri, Mar 31, 2017 at 12:06 PM, Richard Biener > wrote: >>> Does the foll

Re: Fix ICE with -fauto-profile when walking vdefs

2017-04-19 Thread Martin Liška
On 04/18/2017 08:05 PM, Sebastian Pop wrote: On Mon, Apr 3, 2017 at 5:34 AM, Richard Biener wrote: On Fri, 31 Mar 2017, Sebastian Pop wrote: On Fri, Mar 31, 2017 at 12:06 PM, Richard Biener wrote: Does the following fix it? Index: gcc/auto-profile.c

Re: Fix ICE with -fauto-profile when walking vdefs

2017-04-18 Thread Sebastian Pop
On Mon, Apr 3, 2017 at 5:34 AM, Richard Biener wrote: > On Fri, 31 Mar 2017, Sebastian Pop wrote: > >> On Fri, Mar 31, 2017 at 12:06 PM, Richard Biener wrote: > Does the following fix it? > > Index: gcc/auto-profile.c > === > --- gcc

Re: Fix ICE with -fauto-profile when walking vdefs

2017-04-03 Thread Richard Biener
On Fri, 31 Mar 2017, Sebastian Pop wrote: > On Fri, Mar 31, 2017 at 12:06 PM, Richard Biener wrote: > > That's not a default definition but bogus SSA form. You have to fix that, > > not this symptom. > > > > Ok. > It also crashes when adding a call to verifty_ssa > > diff --git a/gcc/auto-pro

Re: Fix ICE with -fauto-profile when walking vdefs

2017-04-03 Thread Richard Biener
On Fri, 31 Mar 2017, Sebastian Pop wrote: > On Fri, Mar 31, 2017 at 1:50 PM, Richard Biener wrote: > > That looks like a workaround rather than the correct fix. Who sets .MEM? > > It should assign the proper def. > > > > Moving the auto_profile pass above several other passes fixes the problem

Re: Fix ICE with -fauto-profile when walking vdefs

2017-03-31 Thread Sebastian Pop
On Fri, Mar 31, 2017 at 1:50 PM, Richard Biener wrote: > That looks like a workaround rather than the correct fix. Who sets .MEM? It > should assign the proper def. > Moving the auto_profile pass above several other passes fixes the problem. The minimal change to fix the problem is by disabling

Re: Fix ICE with -fauto-profile when walking vdefs

2017-03-31 Thread Richard Biener
On March 31, 2017 8:10:51 PM GMT+02:00, Sebastian Pop wrote: >On Fri, Mar 31, 2017 at 12:06 PM, Richard Biener >wrote: >> That's not a default definition but bogus SSA form. You have to fix >that, not this symptom. >> > >Ok. >It also crashes when adding a call to verifty_ssa > >diff --git a/gcc/

Re: Fix ICE with -fauto-profile when walking vdefs

2017-03-31 Thread Sebastian Pop
On Fri, Mar 31, 2017 at 12:06 PM, Richard Biener wrote: > That's not a default definition but bogus SSA form. You have to fix that, > not this symptom. > Ok. It also crashes when adding a call to verifty_ssa diff --git a/gcc/auto-profile.c b/gcc/auto-profile.c index 4b21340c6f0..b834a40af4d 10

Re: Fix ICE with -fauto-profile when walking vdefs

2017-03-31 Thread Richard Biener
On March 31, 2017 6:04:32 PM GMT+02:00, Sebastian Pop wrote: >Hi, > >with trunk gcc as of today and gcc releases 6.* and 5.*, >I get an ICE when compiling a large c++ project with autoFDO >at -O1 and above with -fauto-profile=some.gcov > >internal compiler error: tree check: expected ssa_name, hav

Fix ICE with -fauto-profile when walking vdefs

2017-03-31 Thread Sebastian Pop
Hi, with trunk gcc as of today and gcc releases 6.* and 5.*, I get an ICE when compiling a large c++ project with autoFDO at -O1 and above with -fauto-profile=some.gcov internal compiler error: tree check: expected ssa_name, have var_decl in walk_aliased_vdefs_1, at tree-ssa-alias.c:2912 0x1072fe