* PING *
2016-09-21 19:03 GMT+01:00 Alessandro Fanfarillo :
> Thanks Andre.
>
> 2016-09-19 9:55 GMT-06:00 Andre Vehreschild :
>> Hi Alessandro,
>
>> The if in resolve.c at 8837: resolve_failed_image (... is intentional? It is
>> doing nothing. So do you plan to add more code, or will there never b
Thanks Andre.
2016-09-19 9:55 GMT-06:00 Andre Vehreschild :
> Hi Alessandro,
> The if in resolve.c at 8837: resolve_failed_image (... is intentional? It is
> doing nothing. So do you plan to add more code, or will there never be
> anything. If the later I recommend to just put a comment there and
Hi Alessandro,
there are still some violations of the style guide:
contrib/check_GNU_style.sh first_complete_patch_REV2.diff
emits:
Lines should not exceed 80 characters.
154:+ add_sym_2 ("failed_images", GFC_ISYM_FAILED_IMAGES,
CLASS_TRANSFORMATIONAL, ACTUAL_NO, BT_INTEGER, 155:+
Dear all,
the attached patch supports failed images also when -fcoarray=single is used.
Built and regtested on x86_64-pc-linux-gnu.
Cheers,
Alessandro
2016-08-09 5:22 GMT-06:00 Paul Richard Thomas :
> Hi Sandro,
>
> As far as I can see, this is OK barring a couple of minor wrinkles and
> a quest
Thanks Paul,
I fixed the unused -fdump-tree-original on the tests.
About -fcoarray=single, I agree with Andre about not producing code
for failed images functions when running in single-image mode. If you,
or anybody else, thing otherwise I can adjust the functions to return
a constant value (exc
Hi Sandro,
As far as I can see, this is OK barring a couple of minor wrinkles and
a question:
For coarray_failed_images_err.f90 and coarray_image_status_err.f90 you
have used the option -fdump-tree-original without making use of the
tree dump.
Mikael asked you to provide an executable test with
review?
Many thanks!
> On Jun 21, 2016, at 10:59, Alessandro Fanfarillo
> wrote:
>
> * PING *
>
> 2016-06-06 15:05 GMT-06:00 Alessandro Fanfarillo :
>> Dear all,
>>
>> please find in attachment the first patch (of n) for the FAILED IMAGES
>> capabili
* PING *
2016-07-21 13:05 GMT-06:00 Alessandro Fanfarillo :
> Dear Mikael and all,
>
> in attachment the new patch, built and regtested on x86_64-pc-linux-gnu.
>
> Cheers,
> Alessandro
>
> 2016-07-20 13:17 GMT-06:00 Mikael Morin :
>> Le 20/07/2016 à 11:39, Andre Vehreschild a écrit :
>>>
>>> Hi Mi
Dear Mikael and all,
in attachment the new patch, built and regtested on x86_64-pc-linux-gnu.
Cheers,
Alessandro
2016-07-20 13:17 GMT-06:00 Mikael Morin :
> Le 20/07/2016 à 11:39, Andre Vehreschild a écrit :
>>
>> Hi Mikael,
>>
>>
+ if(st == ST_FAIL_IMAGE)
+new_st.op = EXEC_FAIL_I
Le 20/07/2016 à 11:39, Andre Vehreschild a écrit :
Hi Mikael,
+ if(st == ST_FAIL_IMAGE)
+new_st.op = EXEC_FAIL_IMAGE;
+ else
+gcc_unreachable();
You can use
gcc_assert (st == ST_FAIL_IMAGE);
foo...;
instead of
if (st == ST_FAIL_IMAGE)
foo...;
Hi Mikael,
> > + if(st == ST_FAIL_IMAGE)
> > +new_st.op = EXEC_FAIL_IMAGE;
> > + else
> > +gcc_unreachable();
> You can use
> gcc_assert (st == ST_FAIL_IMAGE);
> foo...;
> instead of
> if (st == ST_FAIL_IMAGE)
> foo...;
> else
> gcc_
Alessandro Fanfarillo :
Dear all,
please find in attachment the first patch (of n) for the FAILED IMAGES
capability defined in the coarray TS 18508.
The patch adds support for three new intrinsic functions defined in
the TS for simulating a failure (fail image), checking an image status
Third *PING*
2016-07-04 16:46 GMT-06:00 Alessandro Fanfarillo :
> * PING *
>
> 2016-06-21 10:59 GMT-06:00 Alessandro Fanfarillo :
>> * PING *
>>
>> 2016-06-06 15:05 GMT-06:00 Alessandro Fanfarillo :
>>> Dear all,
>>>
>>> please find in a
* PING *
2016-06-21 10:59 GMT-06:00 Alessandro Fanfarillo :
> * PING *
>
> 2016-06-06 15:05 GMT-06:00 Alessandro Fanfarillo :
>> Dear all,
>>
>> please find in attachment the first patch (of n) for the FAILED IMAGES
>> capability defined in the coarray TS 185
* PING *
2016-06-06 15:05 GMT-06:00 Alessandro Fanfarillo :
> Dear all,
>
> please find in attachment the first patch (of n) for the FAILED IMAGES
> capability defined in the coarray TS 18508.
> The patch adds support for three new intrinsic functions defined in
> the TS for si
Dear all,
please find in attachment the first patch (of n) for the FAILED IMAGES
capability defined in the coarray TS 18508.
The patch adds support for three new intrinsic functions defined in
the TS for simulating a failure (fail image), checking an image status
(image_status) and getting the
Daniel Carrera wrote:
I think I understand the problem. We have:
if (count == 0 || (count == 1 && images[0] == caf_this_image))
*stat = 0;
Well, you could have kept the return:
if (count == 0 || (count == 1&& images[0] == caf_this_image))
-return 0;
+*stat = 0;
Tobias
17 matches
Mail list logo
