Re: FDO usability patch -- correct insane profile data

2011-04-19 Thread Xinliang David Li
I reverted the original patch and added the assertion instead. Thanks, David On Sun, Apr 17, 2011 at 2:31 PM, Jan Hubicka wrote: >> Adding assertion sounds good to me -- the only problem is that problem >> like this hard to be triggered during testing, thus making assertion >> less useful as it

Re: FDO usability patch -- correct insane profile data

2011-04-17 Thread Jan Hubicka
> Adding assertion sounds good to me -- the only problem is that problem > like this hard to be triggered during testing, thus making assertion > less useful as it can be. Is it better to add the assertion with > checking is enabled while still keeping the correction code? Hi, since we speak about

Re: FDO usability patch -- correct insane profile data

2011-04-17 Thread Xinliang David Li
Adding assertion sounds good to me -- the only problem is that problem like this hard to be triggered during testing, thus making assertion less useful as it can be. Is it better to add the assertion with checking is enabled while still keeping the correction code? Thanks, David On Sun, Apr 17,

Re: FDO usability patch -- correct insane profile data

2011-04-17 Thread Jan Hubicka
Hi, hmm, looks we both run into same issue and developed different fixes. > > Good point. The change above was added based on 4.4.3 where the sum > computation has no capping like above. Yes, with the current capping, > the negative value won't result. However, it is still good to guard > the scal

Re: FDO usability patch -- correct insane profile data

2011-04-17 Thread Xinliang David Li
On Sun, Apr 17, 2011 at 8:29 AM, Jan Hubicka wrote: >> Hi please review the attached patch. >> >> Ok when bootstrap and test finish? >> >> Thanks, >> >> David >> >> >> >> 2011-04-07  Xinliang David Li   >> >>       * ipa-cp.c (ipcp_update_profiling): Correct >>       negative scale factor due to i

Re: FDO usability patch -- correct insane profile data

2011-04-17 Thread Jan Hubicka
> Hi please review the attached patch. > > Ok when bootstrap and test finish? > > Thanks, > > David > > > > 2011-04-07 Xinliang David Li > > * ipa-cp.c (ipcp_update_profiling): Correct > negative scale factor due to insane profile data. > Index: ipa-cp.c > ===

Re: FDO usability patch -- correct insane profile data

2011-04-08 Thread Richard Guenther
On Fri, Apr 8, 2011 at 1:39 AM, Xinliang David Li wrote: > Hi please review the attached patch. > > Ok when bootstrap and test finish? Ok. Thanks, Richard. > Thanks, > > David > > > > 2011-04-07  Xinliang David Li   > >        * ipa-cp.c (ipcp_update_profiling): Correct >        negative scale

FDO usability patch -- correct insane profile data

2011-04-07 Thread Xinliang David Li
Hi please review the attached patch. Ok when bootstrap and test finish? Thanks, David 2011-04-07 Xinliang David Li * ipa-cp.c (ipcp_update_profiling): Correct negative scale factor due to insane profile data. Index: ipa-cp.c