Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-28 Thread Jonathan Yong via Gcc-patches
On 3/28/23 10:43, Costas Argyris wrote: I forgot to update the relevant comments with the previous patch. This is a comment-only patch that brings them up-to-date. Done, thanks.

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-28 Thread Costas Argyris via Gcc-patches
I forgot to update the relevant comments with the previous patch. This is a comment-only patch that brings them up-to-date. On Tue, 28 Mar 2023 at 09:05, Jonathan Yong <10wa...@gmail.com> wrote: > On 3/27/23 17:17, Costas Argyris wrote: > > The patch attached to this email extends the UTF-8 supp

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-28 Thread Jonathan Yong via Gcc-patches
On 3/27/23 17:17, Costas Argyris wrote: The patch attached to this email extends the UTF-8 support of the driver and compiler processes to the 32-bit mingw host.Initially, only the 64-bit host got it. About the changes in sym-mingw32.cc: Even though the 64-bit host was building fine with th

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-27 Thread Costas Argyris via Gcc-patches
The patch attached to this email extends the UTF-8 support of the driver and compiler processes to the 32-bit mingw host.Initially, only the 64-bit host got it. About the changes in sym-mingw32.cc: Even though the 64-bit host was building fine with the symbol being simply declared as a char,

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-09 Thread Jonathan Yong via Gcc-patches
On 3/9/23 13:33, Costas Argyris wrote: Pinging the list and mingw maintainer. Analysis and pre-approval here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865 Thanks, pushed to master branch.

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-09 Thread Costas Argyris via Gcc-patches
Pinging the list and mingw maintainer. Analysis and pre-approval here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865 On Wed, 8 Mar 2023 at 10:52, Costas Argyris wrote: > Added .manifest file to the make rule for utf8rc-mingw32.o, latest patch > attached. > > On Tue, 7 Mar 2023 at 15:27,

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-08 Thread Costas Argyris via Gcc-patches
Added .manifest file to the make rule for utf8rc-mingw32.o, latest patch attached. On Tue, 7 Mar 2023 at 15:27, Costas Argyris wrote: > Hi Jacek, > > "but I think it should work just fine if you didn't explicitly limit the > patch to x86_64." > > I would think so too. > > Actually, even cygwin m

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-07 Thread Costas Argyris via Gcc-patches
Hi Jacek, "but I think it should work just fine if you didn't explicitly limit the patch to x86_64." I would think so too. Actually, even cygwin might benefit from this, assuming it has the same problem, which I don't know if it's the case. But I'm not experienced with that so I would like to e

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-07 Thread Jacek Caban via Gcc-patches
Hi Costas, On 3/7/23 15:00, Costas Argyris wrote: Hi Jacek, "Is there a reason to make it specific to x86_64? It seems to me that all mingw hosts could use it." Are you referring to the 32-bit host?    My concern here is that this functionality (embedding the UTF-8 manifest file into the ex

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-07 Thread Costas Argyris via Gcc-patches
Hi Jacek, "Is there a reason to make it specific to x86_64? It seems to me that all mingw hosts could use it." Are you referring to the 32-bit host?My concern here is that this functionality (embedding the UTF-8 manifest file into the executable) is only truly supported in recent versions of

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-07 Thread Jacek Caban via Gcc-patches
Hi Costas, On 3/7/23 01:52, Costas Argyris via Gcc-patches wrote: This is a proposal for addressing https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865 by integrating the UTF-8 manifest file into gcc's build process for the 64-bit mingw host. Is there a reason to make it specific to x86_64?

Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-06 Thread Costas Argyris via Gcc-patches
Hi This is a proposal for addressing https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865 by integrating the UTF-8 manifest file into gcc's build process for the 64-bit mingw host. The analysis and discussion leading up to the latest patch are written in the bug report. The patch attached in th