Re: Drop CONSTRUCTOR comparsion from ipa-icf-gimple

2015-10-16 Thread Jan Hubicka
> On Fri, Oct 16, 2015 at 1:46 AM, Richard Biener > wrote: > > On Fri, Oct 16, 2015 at 5:12 AM, Jan Hubicka wrote: > >> Hi, > >> as Richard noticed in my port of the code to operand_equal_p, the checking > >> of > >> CONSTURCTOR in ipa-icf-gimple is incomplete missing the index checks. > >> It i

Re: Drop CONSTRUCTOR comparsion from ipa-icf-gimple

2015-10-16 Thread H.J. Lu
On Fri, Oct 16, 2015 at 1:46 AM, Richard Biener wrote: > On Fri, Oct 16, 2015 at 5:12 AM, Jan Hubicka wrote: >> Hi, >> as Richard noticed in my port of the code to operand_equal_p, the checking of >> CONSTURCTOR in ipa-icf-gimple is incomplete missing the index checks. >> It is also unnecesary si

Re: Drop CONSTRUCTOR comparsion from ipa-icf-gimple

2015-10-16 Thread Richard Biener
On Fri, Oct 16, 2015 at 5:12 AM, Jan Hubicka wrote: > Hi, > as Richard noticed in my port of the code to operand_equal_p, the checking of > CONSTURCTOR in ipa-icf-gimple is incomplete missing the index checks. > It is also unnecesary since non-empty ctors does not happen as gimple > operands. Thi

Drop CONSTRUCTOR comparsion from ipa-icf-gimple

2015-10-15 Thread Jan Hubicka
Hi, as Richard noticed in my port of the code to operand_equal_p, the checking of CONSTURCTOR in ipa-icf-gimple is incomplete missing the index checks. It is also unnecesary since non-empty ctors does not happen as gimple operands. This patch thus removes the unnecesary code. Bootstrapped/regtest