Re: Documentation of LTIME

2016-12-19 Thread Janus Weil
6-11-26 21:45 GMT+01:00 Janus Weil : >>> If not, we definitely need to fix the documentation of LTIME, since >>> the current version simply does not work with TIME8(), unless one uses >>> -fdefault-integer-8 (which is not mentioned in the docu). >> >> What a

Re: Documentation of LTIME

2016-11-26 Thread Janus Weil
>> If not, we definitely need to fix the documentation of LTIME, since >> the current version simply does not work with TIME8(), unless one uses >> -fdefault-integer-8 (which is not mentioned in the docu). > > What about the attached patch Yes, looks good to me. Ok t

Re: Documentation of LTIME

2016-11-26 Thread Dominique d'Humières
> Still, since we internally already have both implementations for > kind=4 and kind=8, we could as well make use of them, I guess. I let this for people understanding what to do. > If not, we definitely need to fix the documentation of LTIME, since > the current version simply d

Re: Documentation of LTIME

2016-11-26 Thread Janus Weil
; > LTIME, ITIME, TIME, TIME8, IDATE are g77 intrinsics, from back before > newfangled things like kinds. So there are versions for integer kind=4 > and kind=8 due to -fdefault-integer-8. Ok, I see. Thanks for the comment. Still, since we internally already have both implementations for kind=4 a

Re: Documentation of LTIME

2016-11-26 Thread Janne Blomqvist
On Sat, Nov 26, 2016 at 7:03 PM, Janus Weil wrote: > 2016-11-26 17:58 GMT+01:00 Janus Weil : * possibly add some more cross-links to intrinsic.texi >>> >>> Could you please elaborate? >> >> I just mean it might be useful to add some more links from LTIME to >> ITIME, IDATE and DATE_AND_DATE (

Re: Documentation of LTIME

2016-11-26 Thread Janus Weil
2016-11-26 17:58 GMT+01:00 Janus Weil : >>> * possibly add some more cross-links to intrinsic.texi >> >> Could you please elaborate? > > I just mean it might be useful to add some more links from LTIME to > ITIME, IDATE and DATE_AND_DATE (and back?). They are are all very > similar. Sorry, I meant

Re: Documentation of LTIME

2016-11-26 Thread Janus Weil
>> * possibly add some more cross-links to intrinsic.texi > > Could you please elaborate? I just mean it might be useful to add some more links from LTIME to ITIME, IDATE and DATE_AND_DATE (and back?). They are are all very similar. >> And one last point: The description of LTIME mentions TIME8

Re: Documentation of LTIME

2016-11-26 Thread Dominique d'Humières
> Le 26 nov. 2016 à 17:00, Janus Weil a écrit : > > And one last point: The description of LTIME mentions TIME8, but if I try > this: > > call ltime(time8(), values) > > I get: > > Error: ‘time’ argument of ‘ltime’ intrinsic at (1) must be of kind 4 Well LTIME cannot accept both kind(4) an

Re: Documentation of LTIME

2016-11-26 Thread Dominique d'Humières
> Le 26 nov. 2016 à 16:54, Janus Weil a écrit : > > 2016-11-26 16:49 GMT+01:00 Dominique d'Humières : >> If there is no objection, I’ll commit the following patch > > Looks good to me! > > If you want, you could also fix the remaining items I mentioned in > comment 1 in the PR: > * apply the s

Re: Documentation of LTIME

2016-11-26 Thread Francisco Pena
Dominique, your patch sounds good to me. 2016-11-26 16:49 GMT+01:00 Dominique d'Humières : > If there is no objection, I’ll commit the following patch > > --- ../_clean/gcc/fortran/intrinsic.texi2016-11-25 22:03:20.0 > +0100 > +++ gcc/fortran/intrinsic.texi 2016-11-26 16:47:12.0

Re: Documentation of LTIME

2016-11-26 Thread Janus Weil
And one last point: The description of LTIME mentions TIME8, but if I try this: call ltime(time8(), values) I get: Error: ‘time’ argument of ‘ltime’ intrinsic at (1) must be of kind 4 So maybe the reference to TIME8 should be replaced by TIME? Cheers, Janus 2016-11-26 16:54 GMT+01:00 Janu

Re: Documentation of LTIME

2016-11-26 Thread Janus Weil
2016-11-26 16:49 GMT+01:00 Dominique d'Humières : > If there is no objection, I’ll commit the following patch Looks good to me! If you want, you could also fix the remaining items I mentioned in comment 1 in the PR: * apply the same fix to GMTIME * fix it in the libgfortran sources as well * poss

Re: Documentation of LTIME

2016-11-26 Thread Dominique d'Humières
If there is no objection, I’ll commit the following patch --- ../_clean/gcc/fortran/intrinsic.texi2016-11-25 22:03:20.0 +0100 +++ gcc/fortran/intrinsic.texi 2016-11-26 16:47:12.0 +0100 @@ -9663,11 +9663,11 @@ The elements of @var{VALUES} are assigne seconds @item Minute