Re: Disable tracer by default for profile use (issue4428074)

2011-04-29 Thread Jan Hubicka
> 2011/4/29 Sharad Singhai (? ???) : > > On Thu, Apr 28, 2011 at 4:38 PM, Richard Guenther > > wrote: > >> > >> On Fri, Apr 29, 2011 at 1:34 AM, Xinliang David Li > >> wrote: > >> > Sharad can provide some some performance data -- we have seen up to 2% > >> > degradation to wi

Re: Disable tracer by default for profile use (issue4428074)

2011-04-29 Thread dnovillo
On 2011/04/28 18:53:24, Diego Novillo wrote: OK. Committed rev 173186. Diego. http://codereview.appspot.com/4428074/

Re: Disable tracer by default for profile use (issue4428074)

2011-04-29 Thread Richard Guenther
2011/4/29 Sharad Singhai (शरद सिंघई) : > On Thu, Apr 28, 2011 at 4:38 PM, Richard Guenther > wrote: >> >> On Fri, Apr 29, 2011 at 1:34 AM, Xinliang David Li >> wrote: >> > Sharad can provide some some performance data -- we have seen up to 2% >> > degradation to with tracer turned on for one of g

Re: Disable tracer by default for profile use (issue4428074)

2011-04-28 Thread Xinliang David Li
Tracer is not turned on by default for non-FDO case -- Sharad's change simply turns it off by default for all cases. David On Thu, Apr 28, 2011 at 4:38 PM, Richard Guenther wrote: > On Fri, Apr 29, 2011 at 1:34 AM, Xinliang David Li wrote: >> Sharad can provide some some performance data -- we

Re: Disable tracer by default for profile use (issue4428074)

2011-04-28 Thread Richard Guenther
On Fri, Apr 29, 2011 at 1:34 AM, Xinliang David Li wrote: > Sharad can provide some some performance data -- we have seen up to 2% > degradation to with tracer turned on for one of google's most > important program. Perhaps Sharad can collect some SPEC numbers. > > I agree a better approach should

Re: Disable tracer by default for profile use (issue4428074)

2011-04-28 Thread Xinliang David Li
Sharad can provide some some performance data -- we have seen up to 2% degradation to with tracer turned on for one of google's most important program. Perhaps Sharad can collect some SPEC numbers. I agree a better approach should be to fix the problem in tracer instead of turning it off in trunk.

Re: Disable tracer by default for profile use (issue4428074)

2011-04-28 Thread Richard Guenther
On Thu, Apr 28, 2011 at 8:53 PM, Diego Novillo wrote: > On Thu, Apr 28, 2011 at 14:51, Sharad Singhai wrote: >> This patch disables -ftracer for profile use. Okay for google/main? > > Could you elaborate on why doing this is beneficial?  Are you > proposing this for trunk as well? It indeed does

Re: Disable tracer by default for profile use (issue4428074)

2011-04-28 Thread Diego Novillo
On Thu, Apr 28, 2011 at 14:51, Sharad Singhai wrote: > This patch disables -ftracer for profile use. Okay for google/main? Could you elaborate on why doing this is beneficial? Are you proposing this for trunk as well? > 2011-04-28  Sharad Singhai   > >        Google Ref 40087 >        * opts.c

Disable tracer by default for profile use (issue4428074)

2011-04-28 Thread Sharad Singhai
This patch disables -ftracer for profile use. Okay for google/main? Thanks, Sharad 2011-04-28 Sharad Singhai Google Ref 40087 * opts.c (common_handle_option): Disable -ftracer for profile use. * doc/invoke.texi: Update doc that -ftracer is no longer enabled for FDO.