On Thu, Nov 30, 2023 at 11:58 AM Ian Lance Taylor wrote:
>
> On Thu, Nov 30, 2023 at 11:56 AM Iain Sandoe wrote:
> >
> > > On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote:
> > >
> > > On Sun, Oct 22, 2023 at 2:18 PM FX Coudert wrote:
> > >>
> > >> Thanks a lot Alexandre for the review!
> > >
>
On Thu, Nov 30, 2023 at 11:56 AM Iain Sandoe wrote:
>
> > On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote:
> >
> > On Sun, Oct 22, 2023 at 2:18 PM FX Coudert wrote:
> >>
> >> Thanks a lot Alexandre for the review!
> >
> > This patch changed the files lingo/configure.ac and libgo/configure.
> >
Hi Ian
> On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote:
>
> On Sun, Oct 22, 2023 at 2:18 PM FX Coudert wrote:
>>
>> Thanks a lot Alexandre for the review!
>
> This patch changed the files lingo/configure.ac and libgo/configure.
> Those files live in an upstream repository and should be cha
On Sun, Oct 22, 2023 at 2:18 PM FX Coudert wrote:
>
> Thanks a lot Alexandre for the review!
This patch changed the files lingo/configure.ac and libgo/configure.
Those files live in an upstream repository and should be changed there
and then merged into the GCC repo, as described in libgo/README.
Hi,
> I believe this can be applied as a partial reversion of a previously approved
> patch,
Yes, that makes sense.
Pushed as
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=ce966ae66067d8d365431ef7a323f4207fcb729a
FX
Hi FX,
> On 17 Nov 2023, at 14:20, FX Coudert wrote:
>
>>> I have done a full rebuild, and having looked more at the structure of
>>> libtool.m4 I am now convinced that having that line outside of the scope of
>>> _LT_DARWIN_LINKER_FEATURES is simply wrong (probably a copy-pasto or
>>> leftov
>> I have done a full rebuild, and having looked more at the structure of
>> libtool.m4 I am now convinced that having that line outside of the scope of
>> _LT_DARWIN_LINKER_FEATURES is simply wrong (probably a copy-pasto or
>> leftover from earlier code).
>> Having rebuilt everything, it only m
Hi FX!
On 2023-11-17T12:56:13+0100, FX Coudert wrote:
>> If I remove the line from libtool.m4 (innocent smile) I see that
>> fixincludes/configure is better, and it does not appear to change the
>> regenerated files in other directories (I didn’t do a build yet, just tried
>> to regenerate wit
Hi,
> If I remove the line from libtool.m4 (innocent smile) I see that
> fixincludes/configure is better, and it does not appear to change the
> regenerated files in other directories (I didn’t do a build yet, just tried
> to regenerate with some manual autoconf invocations).
I have done a ful
> So I currently see the following in my build logs:
>
>[...]
>mkdir -p -- ./fixincludes
>Configuring in ./fixincludes
>configure: creating cache ./config.cache
>[...]/source-gcc/fixincludes/configure: line 3030:
> enable_darwin_at_rpath_--srcdir=[...]/source-gcc/fixincludes=n
Hi!
On 2023-10-30T19:08:18+, Iain Sandoe wrote:
>> On 30 Oct 2023, at 16:31, FX Coudert wrote:
>>
>>> +enable_darwin_at_rpath_$1=no
>>
>> I actually don’t understand why this one would have $1 in the name, unlike
>> all other regenerated configure files. What value do we expect for $1 at
>
Hi Folks
> On 30 Oct 2023, at 16:31, FX Coudert wrote:
>
>> +enable_darwin_at_rpath_$1=no
>
> I actually don’t understand why this one would have $1 in the name, unlike
> all other regenerated configure files. What value do we expect for $1 at this
> point in the file? That’s just plain weird
Hi,
> +enable_darwin_at_rpath_$1=no
I actually don’t understand why this one would have $1 in the name, unlike all
other regenerated configure files. What value do we expect for $1 at this point
in the file? That’s just plain weird.
FX
Hi Martin,
> On 30 Oct 2023, at 16:17, Martin Jambor wrote:
> On Tue, Aug 15 2023, FX Coudert via Gcc-patches wrote:
>>
>
> [...]
>
>> From e1cf04cadb9fa065fb3f7d6bccf9ed6f1e9e3fc1 Mon Sep 17 00:00:00 2001
>> From: Iain Sandoe
>> Date: Sun, 28 Mar 2021 14:48:17 +0100
>> Subject: [PATCH 2/4]
Hello Iain,
On Tue, Aug 15 2023, FX Coudert via Gcc-patches wrote:
>
[...]
> From e1cf04cadb9fa065fb3f7d6bccf9ed6f1e9e3fc1 Mon Sep 17 00:00:00 2001
> From: Iain Sandoe
> Date: Sun, 28 Mar 2021 14:48:17 +0100
> Subject: [PATCH 2/4] Darwin: Allow for configuring Darwin to use embedded
> runpath.
Thanks a lot Alexandre for the review!
FX
Hi Jeff,
> On 21 Oct 2023, at 19:05, Jeff Law wrote:
> On 10/8/23 16:14, Iain Sandoe wrote:
>> + Jeff
>>> On 8 Oct 2023, at 14:07, Nathanael Nerode wrote:
>>>
>>> I hope a global maintainer can step up. I've been on hiatus from GCC work
>>> for some years, and this was never my part of the b
On 10/8/23 16:14, Iain Sandoe wrote:
+ Jeff
On 8 Oct 2023, at 14:07, Nathanael Nerode wrote:
I hope a global maintainer can step up. I've been on hiatus from GCC work for
some years, and this was never my part of the build system anyway -- and I
don't use Darwin -- so I'm not qualified
On Aug 29, 2023, FX Coudert wrote:
>> I think a build machinery review is needed.
> Thanks. CC’ing the relevant maintainers for review of the build part.
> The driver part and the darwin-specific part are already okayed.
The build machinery bits look reasonable to me. I have no specific
knowled
+ Jeff
> On 8 Oct 2023, at 14:07, Nathanael Nerode wrote:
>
> I hope a global maintainer can step up. I've been on hiatus from GCC work
> for some years, and this was never my part of the build system anyway -- and
> I don't use Darwin -- so I'm not qualified to review it. It looks fine but
I hope a global maintainer can step up. I've been on hiatus from GCC work for
some years, and this was never my part of the build system anyway -- and I
don't use Darwin -- so I'm not qualified to review it. It looks fine but it
should be reviewed by someone who knows what they're doing.
On W
On Tue, 29 Aug 2023, FX Coudert via Gcc-patches wrote:
> > The driver changes are still OK.
>
> Just to be clear: apart from you and Iain, whose approval do I need (and
> for what parts)?
I think a build machinery review is needed.
--
Joseph S. Myers
jos...@codesourcery.com
On Fri, 25 Aug 2023, FX Coudert via Gcc-patches wrote:
> Hi,
>
> Thanks Joseph for the review.
>
> > The driver changes are OK.
> >
> > I think the new configure options and the new -nodefaultrpaths compiler
> > option need documenting
>
> Doc patch was added, and okay’ed by Iain.
I see docu
> On 18 Aug 2023, at 23:59, Joseph Myers wrote:
>
> On Fri, 18 Aug 2023, Iain Sandoe via Gcc-patches wrote:
>
>> There is quite extensive Apple Developer documentation on delivering
>> packages with co-installed libraries using @rpath (that is the intended
>> mechanism for delivery since it
On Fri, 18 Aug 2023, Iain Sandoe via Gcc-patches wrote:
> There is quite extensive Apple Developer documentation on delivering
> packages with co-installed libraries using @rpath (that is the intended
> mechanism for delivery since it allows drag-and-drop installation and
> moving of built appl
Hi Joseph,
> On 18 Aug 2023, at 21:17, Joseph Myers wrote:
>
> On Tue, 15 Aug 2023, FX Coudert via Gcc-patches wrote:
>
>> I am currently retesting the patches on various archs (Linux and Darwin)
>> after a final rebase, but various previous versions were
>> regression-tested, and have been s
On Tue, 15 Aug 2023, FX Coudert via Gcc-patches wrote:
> I am currently retesting the patches on various archs (Linux and Darwin)
> after a final rebase, but various previous versions were
> regression-tested, and have been shipped for a long time in Homebrew.
>
> OK to commit?
The driver chan
This is a fairly long explanation of the problems being addressed by
the patch set. Most of the changes are Darwin-specific - a change to
the libtool component allowing for this @rpath and some minor additions
to makefiles where libtool is not in use. At present, this seems pretty
specific to the
28 matches
Mail list logo
