[C++] some cleanup patches

I've committed this set of minor cleanups from the modules branch. nathan -- Nathan Sidwell 2020-05-13 Nathan Sidwell Formatting fixups & some simplifications. * pt.c (spec_hash_table): New typedef. (decl_specializations, type_specializations): Use it. (retrieve_specialization): Likewise.

Various small C++ cleanup PATCHes

1) There's a function to count how many template headers we should have, we should use it. 2) While working on something a while back I ran into trying to instantiate a nested function while still in processing_template_decl context, which doesn't work so well. Let's check for that. 3) A predica

2 C++ cleanup PATCHes

1) While working on 66260, it struck me as odd that finish_id_expression had its own code for determining whether an id-expression is dependent, rather than using type_dependent_expression_p. So this patch tears out a bunch of code and replaces it with a call; t_d_e_p already handled everythin

Re: Generalizing existing OpenMP infrastructure (was: Cleanup patches, mostly in the realm of OpenMP)

On Mon, Dec 16, 2013 at 05:49:26PM +0100, Thomas Schwinge wrote: > > > --- gcc/gimplify.c > > > +++ gcc/gimplify.c > > > @@ -129,6 +129,8 @@ struct gimplify_ctx > > >bool in_cleanup_point_expr; > > > }; > > > > > > +/* Variable remapping context. */ > > > > Please mention there OpenMP (and

Re: Cleanup patches, mostly in the realm of OpenMP

Hi! On Mon, 16 Dec 2013 09:58:07 +0100, Jakub Jelinek wrote: > On Fri, Dec 13, 2013 at 11:12:03AM +0100, Thomas Schwinge wrote: > > OK to apply the following cleanup patches to trunk, assuming that testing > > (still running) is fine? Thanks for the review! > > Refle

Generalizing existing OpenMP infrastructure (was: Cleanup patches, mostly in the realm of OpenMP)

Hi! On Mon, 16 Dec 2013 09:58:07 +0100, Jakub Jelinek wrote: > On Fri, Dec 13, 2013 at 11:12:03AM +0100, Thomas Schwinge wrote: > > --- gcc/gimplify.c > > +++ gcc/gimplify.c > > @@ -129,6 +129,8 @@ struct gimplify_ctx > >bool in_cleanup_point_expr; > > }; > > > > +/* Variable remapping con

Re: Cleanup patches, mostly in the realm of OpenMP

On Fri, Dec 13, 2013 at 11:12:03AM +0100, Thomas Schwinge wrote: > OK to apply the following cleanup patches to trunk, assuming that testing > (still running) is fine? > gcc/c/ > * c-parser.c (c_parser_omp_parallel): Fix description. > gcc/cp/ &

Cleanup patches, mostly in the realm of OpenMP

Hi! OK to apply the following cleanup patches to trunk, assuming that testing (still running) is fine? commit 68c9deec084dff1e5d8caf6a17ec3eec1f8f9f33 Author: Thomas Schwinge Date: Wed Oct 23 19:40:10 2013 +0200 Fix description of OpenMP parallel directive in the C and C++ front ends

Two C++ cleanup PATCHes

1) Some changes to constant initialization that were needed by an early version of the "trivial but deleted" patch. They aren't needed anymore, but still seem correct. 2) We had two functions for building cleanup calls, which is unnecessary duplication. Also, there's no point in limiting use

Two tiny C++ cleanup PATCHes

1) We want to skip anonymous structs when pushing member cleanups, too. 2) We shouldn't create a static variable for a compound literal in e.g. sizeof. I don't think either of these will actually affect compiler output, they're just cleanups I noticed while working on other things. Tested x8

Re: Cleanup patches

Hi! On Wed, 9 Oct 2013 11:04:29 +0200, Jakub Jelinek wrote: > The testing _OPENMP value against 201107 won't work after merge, it will be > 201307 instead. The Fortran openmp_version will be still 201107 for now, > as Fortran OpenMP 4.0 support isn't there yet. And: On Wed, 9 Oct 2013 11:13:38

Re: Cleanup patches

Thomas Schwinge wrote: > Meanwhile, here's another series that I assumed had gotten lost, but now > recovered thanks to Âgit fsckÂ. Also OK to commit? > > _OPENMP pre-processor checks, openmp_version Fortran instrinsic checks. Two remarks: * When Jakub's patch gets it, one needs to update the C/

Re: Cleanup patches

On Wed, Oct 09, 2013 at 10:56:25AM +0200, Thomas Schwinge wrote: > On Tue, 8 Oct 2013 22:04:23 +0200, Jakub Jelinek wrote: > > On Tue, Oct 08, 2013 at 09:17:35AM +0200, Thomas Schwinge wrote: > > > Here are a few cleanup patches, mostly in the realm of OpenMP, so Jakub >

Re: Cleanup patches

Hi! On Tue, 8 Oct 2013 22:04:23 +0200, Jakub Jelinek wrote: > On Tue, Oct 08, 2013 at 09:17:35AM +0200, Thomas Schwinge wrote: > > Here are a few cleanup patches, mostly in the realm of OpenMP, so Jakub > > gets a CC. OK to commit? > > They look ok to me, but I'd

Re: Cleanup patches

On Tue, Oct 08, 2013 at 09:17:35AM +0200, Thomas Schwinge wrote: > Here are a few cleanup patches, mostly in the realm of OpenMP, so Jakub > gets a CC. OK to commit? They look ok to me, but I'd prefer if they could go in after the merge I've just posted. Jakub

Cleanup patches

Hi! Here are a few cleanup patches, mostly in the realm of OpenMP, so Jakub gets a CC. OK to commit? libgomp/ * omp.h.in: Don't touch the user's namespace. --- libgomp/omp.h.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git libgomp/omp.h.in libgom

Re: A couple of small C++ cleanup PATCHes

One more: I noticed that we were calling require_complete_type within template-specific code, but in a template require_complete_type just returns immediately. Tested x86_64-pc-linux-gnu, applying to trunk. commit 453649bdbc1189503b34774d5a6cf2470a6bcd12 Author: Jason Merrill Date: Wed Mar

A couple of small C++ cleanup PATCHes

Conversion of default arguments is an implicit conversion, so it should use LOOKUP_IMPLICIT. A recent bug involved cp_parser_abort_tentative_parse failing to abort because we had already committed to the tentative parse. So let's avoid that in future. Tested x86_64-pc-linux-gnu, applied to