Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 16, 2020 at 8:01 PM Ian Lance Taylor wrote: > > Thanks for the pointer to git-verify. It also fails. It looks like > when the file name contains a non-ASCII character, it comes back with > quotation marks around it. That causes the test "if > path.startswith(ignored):" in git_commit

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 16, 2020 at 7:38 PM Kewen.Lin wrote: > > With the helper gcc-verify from contrib/gcc-git-customization.sh [1], > you can verify your local commit to meet required ChangeLog formats. > Does gcc-verify claim that it's ok locally? > > If no, probably you can amend the commit message with

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Kewen.Lin via Gcc-patches
on 2020/12/17 上午11:26, Ian Lance Taylor wrote: > On Wed, Dec 16, 2020 at 6:54 PM Kewen.Lin wrote: >> >> on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: >>> On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote:

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 16, 2020 at 6:54 PM Kewen.Lin wrote: > > on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: > > On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: > >> > >> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote: > >>> > >>> I'm trying to commit a change that adds a b

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-16 Thread Kewen.Lin via Gcc-patches
Hi Ian, on 2020/12/16 上午7:53, Ian Lance Taylor via Gcc-patches wrote: > On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: >> >> On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote: >>> >>> I'm trying to commit a change that adds a bunch of new files to >>> gcc/testsuite/go.test/test. I

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-15 Thread Ian Lance Taylor via Gcc-patches
On Tue, Dec 15, 2020 at 3:51 PM Ian Lance Taylor wrote: > > On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote: > > > > I'm trying to commit a change that adds a bunch of new files to > > gcc/testsuite/go.test/test. It's being rejected because the hook > > can't deduce a ChangeLog file. But

Re: Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-15 Thread Ian Lance Taylor via Gcc-patches
On Tue, Dec 15, 2020 at 3:43 PM Ian Lance Taylor wrote: > > I'm trying to commit a change that adds a bunch of new files to > gcc/testsuite/go.test/test. It's being rejected because the hook > can't deduce a ChangeLog file. But this directory has no ChangeLog > files. I've committed other chang

Change to gcc/testsuite/go.test/test rejected by ChangeLog checker

2020-12-15 Thread Ian Lance Taylor via Gcc-patches
I'm trying to commit a change that adds a bunch of new files to gcc/testsuite/go.test/test. It's being rejected because the hook can't deduce a ChangeLog file. But this directory has no ChangeLog files. I've committed other changes to this directory without a ChangeLog entry. What is going wron