Re: CRIS atomics revisited 4/4: give up on alignment of atomic data, RFC for is_lock_free hook

2012-07-17 Thread Andrew MacLeod
On 07/17/2012 06:55 PM, Hans-Peter Nilsson wrote: From: Andrew MacLeod Date: Tue, 17 Jul 2012 14:24:48 +0200 Any PR's you open related this this, copy me on them and I'll try to get them addressed. I could separate the issues I saw into PRs 54003-6. That's all, hopefully ...at least for now. :

Re: CRIS atomics revisited 4/4: give up on alignment of atomic data, RFC for is_lock_free hook

2012-07-17 Thread Hans-Peter Nilsson
> From: Andrew MacLeod > Date: Tue, 17 Jul 2012 14:24:48 +0200 > Any PR's you open related this this, copy me on them and I'll try to get > them addressed. I could separate the issues I saw into PRs 54003-6. That's all, hopefully ...at least for now. :) BTW, your @gcc.gnu.org account doesn't

Re: CRIS atomics revisited 4/4: give up on alignment of atomic data, RFC for is_lock_free hook

2012-07-17 Thread Hans-Peter Nilsson
> From: Andrew MacLeod > Date: Tue, 17 Jul 2012 14:24:48 +0200 > On 07/15/2012 11:49 PM, Hans-Peter Nilsson wrote: > > Well, give up by default that is, and fix it up in a helper > > function in glibc to hold a global byte-sized atomic lock for > > the duration. (Sorry!) Yes, this means that >

Re: CRIS atomics revisited 4/4: give up on alignment of atomic data, RFC for is_lock_free hook

2012-07-17 Thread Andrew MacLeod
On 07/15/2012 11:49 PM, Hans-Peter Nilsson wrote: Well, give up by default that is, and fix it up in a helper function in glibc to hold a global byte-sized atomic lock for the duration. (Sorry!) Yes, this means that fold_builtin_atomic_always_lock_free is wrong. It knows about alignment in gen

Re: CRIS atomics revisited 4/4: give up on alignment of atomic data

2012-07-15 Thread Hans-Peter Nilsson
> From: Hans-Peter Nilsson > Date: Mon, 16 Jul 2012 05:49:00 +0200 > gcc: > * config/cris/sync.md ("atomic_fetch_") > ("cris_atomic_fetch__1") > ("atomic_compare_and_swap") > ("cris_atomic_compare_and_swap_1"): Make > conditional on TARGET_ATOMICS_MAY_CALL_LIBFUNCS

CRIS atomics revisited 4/4: give up on alignment of atomic data, RFC for is_lock_free hook

2012-07-15 Thread Hans-Peter Nilsson
Well, give up by default that is, and fix it up in a helper function in glibc to hold a global byte-sized atomic lock for the duration. (Sorry!) Yes, this means that fold_builtin_atomic_always_lock_free is wrong. It knows about alignment in general but doesn't handle the case where the default a