Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v4]

2018-10-30 Thread Jason Merrill
On 10/29/18 6:15 PM, Marek Polacek wrote: On Wed, Oct 24, 2018 at 02:55:14PM -0400, Jason Merrill wrote: On 10/12/18 12:32 PM, Marek Polacek wrote: + EXPLICIT_SPECIFIER is used in case the explicit-specifier, if any, has + value-dependent expression. */ static void cp_parser_decl_speci

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v4]

2018-10-29 Thread Marek Polacek
On Wed, Oct 24, 2018 at 02:55:14PM -0400, Jason Merrill wrote: > On 10/12/18 12:32 PM, Marek Polacek wrote: > > + EXPLICIT_SPECIFIER is used in case the explicit-specifier, if any, has > > + value-dependent expression. */ > > static void > > cp_parser_decl_specifier_seq (cp_parser* parser, >

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v3]

2018-10-24 Thread Jason Merrill
On 10/12/18 12:32 PM, Marek Polacek wrote: + EXPLICIT_SPECIFIER is used in case the explicit-specifier, if any, has + value-dependent expression. */ static void cp_parser_decl_specifier_seq (cp_parser* parser, cp_parser_flags flags,

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v3]

2018-10-19 Thread Marek Polacek
Ping. On Fri, Oct 12, 2018 at 12:32:43PM -0400, Marek Polacek wrote: > On Fri, Oct 12, 2018 at 02:26:45AM -0400, Jason Merrill wrote: > > On Thu, Oct 11, 2018 at 8:25 PM Marek Polacek wrote: > > > > > > On Thu, Oct 11, 2018 at 11:35:23AM -0400, Jason Merrill wrote: > > > > > + /* [dcl.fct.s

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v3]

2018-10-12 Thread Marek Polacek
On Fri, Oct 12, 2018 at 02:26:45AM -0400, Jason Merrill wrote: > On Thu, Oct 11, 2018 at 8:25 PM Marek Polacek wrote: > > > > On Thu, Oct 11, 2018 at 11:35:23AM -0400, Jason Merrill wrote: > > > > + /* [dcl.fct.spec] > > > > + "the constant-expression, if supplied, shall be a > > >

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v2]

2018-10-11 Thread Jason Merrill
On Thu, Oct 11, 2018 at 8:25 PM Marek Polacek wrote: > > On Thu, Oct 11, 2018 at 11:35:23AM -0400, Jason Merrill wrote: > > > + /* [dcl.fct.spec] > > > + "the constant-expression, if supplied, shall be a contextually > > > + converted constant expression of type bool." */

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v2]

2018-10-11 Thread Marek Polacek
On Thu, Oct 11, 2018 at 11:35:23AM -0400, Jason Merrill wrote: > > + /* [dcl.fct.spec] > > + "the constant-expression, if supplied, shall be a contextually > > + converted constant expression of type bool." */ > > + expr = build_explicit_specifier (expr, tf_warning_or

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v2]

2018-10-11 Thread Jason Merrill
On Wed, Oct 3, 2018 at 7:11 PM Marek Polacek wrote: > > On Wed, Oct 03, 2018 at 10:24:52AM -0400, Jason Merrill wrote: > > On Tue, Oct 2, 2018 at 5:25 PM Marek Polacek wrote: > > > > > > On Mon, Oct 01, 2018 at 07:47:10PM -0400, Jason Merrill wrote: > > > > On Mon, Oct 1, 2018 at 6:41 PM Marek Po

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v2]

2018-10-10 Thread Marek Polacek
Ping. On Wed, Oct 03, 2018 at 07:11:37PM -0400, Marek Polacek wrote: > On Wed, Oct 03, 2018 at 10:24:52AM -0400, Jason Merrill wrote: > > On Tue, Oct 2, 2018 at 5:25 PM Marek Polacek wrote: > > > > > > On Mon, Oct 01, 2018 at 07:47:10PM -0400, Jason Merrill wrote: > > > > On Mon, Oct 1, 2018 at 6

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v2]

2018-10-03 Thread Marek Polacek
On Wed, Oct 03, 2018 at 10:24:52AM -0400, Jason Merrill wrote: > On Tue, Oct 2, 2018 at 5:25 PM Marek Polacek wrote: > > > > On Mon, Oct 01, 2018 at 07:47:10PM -0400, Jason Merrill wrote: > > > On Mon, Oct 1, 2018 at 6:41 PM Marek Polacek wrote: > > > > > > > > This patch implements C++20 explici

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool)

2018-10-03 Thread Marek Polacek
On Wed, Oct 03, 2018 at 07:44:03PM +0200, Jakub Jelinek wrote: > On Wed, Oct 03, 2018 at 12:30:28PM -0400, Nathan Sidwell wrote: > > On 10/1/18 7:47 PM, Jason Merrill wrote: > > > On Mon, Oct 1, 2018 at 6:41 PM Marek Polacek wrote: > > > > > > > > This patch implements C++20 explicit(bool), as de

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool)

2018-10-03 Thread Jakub Jelinek
On Wed, Oct 03, 2018 at 12:30:28PM -0400, Nathan Sidwell wrote: > On 10/1/18 7:47 PM, Jason Merrill wrote: > > On Mon, Oct 1, 2018 at 6:41 PM Marek Polacek wrote: > > > > > > This patch implements C++20 explicit(bool), as described in: > > >

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool)

2018-10-03 Thread Nathan Sidwell
On 10/2/18 5:25 PM, Marek Polacek wrote: On Mon, Oct 01, 2018 at 07:47:10PM -0400, Jason Merrill wrote: On Mon, Oct 1, 2018 at 6:41 PM Marek Polacek wrote: This patch implements C++20 explicit(bool), as described in: . I t

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool)

2018-10-03 Thread Nathan Sidwell
On 10/1/18 7:47 PM, Jason Merrill wrote: On Mon, Oct 1, 2018 at 6:41 PM Marek Polacek wrote: This patch implements C++20 explicit(bool), as described in: . I tried to follow the noexcept specifier implementation where I cou

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool)

2018-10-03 Thread Jason Merrill
On Tue, Oct 2, 2018 at 5:25 PM Marek Polacek wrote: > > On Mon, Oct 01, 2018 at 07:47:10PM -0400, Jason Merrill wrote: > > On Mon, Oct 1, 2018 at 6:41 PM Marek Polacek wrote: > > > > > > This patch implements C++20 explicit(bool), as described in: > > >

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool)

2018-10-02 Thread Marek Polacek
On Mon, Oct 01, 2018 at 07:47:10PM -0400, Jason Merrill wrote: > On Mon, Oct 1, 2018 at 6:41 PM Marek Polacek wrote: > > > > This patch implements C++20 explicit(bool), as described in: > > . > > > > I tried to follow the noexce

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool)

2018-10-01 Thread Jason Merrill
On Mon, Oct 1, 2018 at 6:41 PM Marek Polacek wrote: > > This patch implements C++20 explicit(bool), as described in: > . > > I tried to follow the noexcept specifier implementation where I could, which > made the non-template pa

C++ PATCH to implement C++20 P0892R2 - explicit(bool)

2018-10-01 Thread Marek Polacek
This patch implements C++20 explicit(bool), as described in: . I tried to follow the noexcept specifier implementation where I could, which made the non-template parts of this fairly easy. To make explicit(expr) work with depen