Re: C++ PATCH to fix an ICE on invalid with OVERLOADs (PR c++/84854)

2018-04-03 Thread Jason Merrill
On Wed, Mar 21, 2018 at 4:14 PM, Marek Polacek wrote: > On Wed, Mar 21, 2018 at 02:55:36PM -0400, Jason Merrill wrote: >> On Wed, Mar 21, 2018 at 2:37 PM, Marek Polacek wrote: >> > On Thu, Mar 15, 2018 at 08:55:59AM -0400, Jason Merrill wrote: >> >> On Thu, Mar 15, 2018 at 7:49 AM, Marek Polacek

Re: C++ PATCH to fix an ICE on invalid with OVERLOADs (PR c++/84854)

2018-03-21 Thread Marek Polacek
On Wed, Mar 21, 2018 at 02:55:36PM -0400, Jason Merrill wrote: > On Wed, Mar 21, 2018 at 2:37 PM, Marek Polacek wrote: > > On Thu, Mar 15, 2018 at 08:55:59AM -0400, Jason Merrill wrote: > >> On Thu, Mar 15, 2018 at 7:49 AM, Marek Polacek wrote: > >> > On Wed, Mar 14, 2018 at 02:06:36PM -0400, Jas

Re: C++ PATCH to fix an ICE on invalid with OVERLOADs (PR c++/84854)

2018-03-21 Thread Jason Merrill
On Wed, Mar 21, 2018 at 2:37 PM, Marek Polacek wrote: > On Thu, Mar 15, 2018 at 08:55:59AM -0400, Jason Merrill wrote: >> On Thu, Mar 15, 2018 at 7:49 AM, Marek Polacek wrote: >> > On Wed, Mar 14, 2018 at 02:06:36PM -0400, Jason Merrill wrote: >> >> On Wed, Mar 14, 2018 at 11:59 AM, Marek Polacek

Re: C++ PATCH to fix an ICE on invalid with OVERLOADs (PR c++/84854)

2018-03-21 Thread Marek Polacek
On Thu, Mar 15, 2018 at 08:55:59AM -0400, Jason Merrill wrote: > On Thu, Mar 15, 2018 at 7:49 AM, Marek Polacek wrote: > > On Wed, Mar 14, 2018 at 02:06:36PM -0400, Jason Merrill wrote: > >> On Wed, Mar 14, 2018 at 11:59 AM, Marek Polacek wrote: > >> > cxx_constant_value doesn't understand templa

Re: C++ PATCH to fix an ICE on invalid with OVERLOADs (PR c++/84854)

2018-03-15 Thread Jason Merrill
On Thu, Mar 15, 2018 at 7:49 AM, Marek Polacek wrote: > On Wed, Mar 14, 2018 at 02:06:36PM -0400, Jason Merrill wrote: >> On Wed, Mar 14, 2018 at 11:59 AM, Marek Polacek wrote: >> > cxx_constant_value doesn't understand template codes, and neither it >> > understands OVERLOADs, so if we pass an O

Re: C++ PATCH to fix an ICE on invalid with OVERLOADs (PR c++/84854)

2018-03-15 Thread Marek Polacek
On Wed, Mar 14, 2018 at 02:06:36PM -0400, Jason Merrill wrote: > On Wed, Mar 14, 2018 at 11:59 AM, Marek Polacek wrote: > > cxx_constant_value doesn't understand template codes, and neither it > > understands OVERLOADs, so if we pass an OVERLOAD to it, we crash. Here > > instantiate_non_dependent

Re: C++ PATCH to fix an ICE on invalid with OVERLOADs (PR c++/84854)

2018-03-14 Thread Jason Merrill
On Wed, Mar 14, 2018 at 11:59 AM, Marek Polacek wrote: > cxx_constant_value doesn't understand template codes, and neither it > understands OVERLOADs, so if we pass an OVERLOAD to it, we crash. Here > instantiate_non_dependent_expr got an OVERLOAD, but since it calls > is_nondependent_constant_ex

C++ PATCH to fix an ICE on invalid with OVERLOADs (PR c++/84854)

2018-03-14 Thread Marek Polacek
cxx_constant_value doesn't understand template codes, and neither it understands OVERLOADs, so if we pass an OVERLOAD to it, we crash. Here instantiate_non_dependent_expr got an OVERLOAD, but since it calls is_nondependent_constant_expression which checks type_unknown_p, it left the expression as