Re: C++ PATCH to fix ICE with noexcept and -fgnu-tm (PR c++/80059)

2017-03-20 Thread Jason Merrill
OK. On Mon, Mar 20, 2017 at 10:36 AM, Marek Polacek wrote: > On Sat, Mar 18, 2017 at 12:47:39PM -0400, Jason Merrill wrote: >> On Fri, Mar 17, 2017 at 10:45 AM, Marek Polacek wrote: >> > + cond = instantiate_non_dependent_expr_sfinae (cond, tf_none); >> >> Why this rather than instantiate_n

Re: C++ PATCH to fix ICE with noexcept and -fgnu-tm (PR c++/80059)

2017-03-20 Thread Marek Polacek
On Sat, Mar 18, 2017 at 12:47:39PM -0400, Jason Merrill wrote: > On Fri, Mar 17, 2017 at 10:45 AM, Marek Polacek wrote: > > + cond = instantiate_non_dependent_expr_sfinae (cond, tf_none); > > Why this rather than instantiate_non_dependent_expr (and so tf_error)? Hmm, I hadn't thought about

Re: C++ PATCH to fix ICE with noexcept and -fgnu-tm (PR c++/80059)

2017-03-18 Thread Jason Merrill
On Fri, Mar 17, 2017 at 10:45 AM, Marek Polacek wrote: > + cond = instantiate_non_dependent_expr_sfinae (cond, tf_none); Why this rather than instantiate_non_dependent_expr (and so tf_error)? Jason

C++ PATCH to fix ICE with noexcept and -fgnu-tm (PR c++/80059)

2017-03-17 Thread Marek Polacek
Paolo recently added the perform_implicit_conversion_flags call in build_must_not_throw_expr which means that COND might now be an IMPLICIT_CONV_EXPR. That means we need to make sure that COND is instantiated before we try to fold it, because we can get here while parsing a template. Me & Paolo