Re: C++ PATCH to add test for c++/90236

2019-04-25 Thread Marek Polacek
On Thu, Apr 25, 2019 at 03:56:40PM -0400, Jason Merrill wrote: > On Wed, Apr 24, 2019 at 5:26 PM Marek Polacek wrote: > > > > This valid test started to be accepted with r265789, which removed the > > following checks. > > It didn't remove them, it moved them into invalid_tparm_referent_p. > And

Re: C++ PATCH to add test for c++/90236

2019-04-25 Thread Jason Merrill
On Wed, Apr 24, 2019 at 5:26 PM Marek Polacek wrote: > > This valid test started to be accepted with r265789, which removed the > following checks. It didn't remove them, it moved them into invalid_tparm_referent_p. And changed the tests for C++17. > I wonder if we want to remove them in gcc 8,

C++ PATCH to add test for c++/90236

2019-04-24 Thread Marek Polacek
This valid test started to be accepted with r265789, which removed the following checks. I wonder if we want to remove them in gcc 8, or just leave them in place. For trunk I'm going to add the new test. @@ -6985,27 +7071,10 @@ convert_nontype_argument (tree type, tree expr, tsubst_flags_t comp