Re: C++ PATCH for c++/91644 - ICE with constinit in function template

2019-09-05 Thread Jason Merrill
On 9/4/19 3:06 PM, Marek Polacek wrote: On Wed, Sep 04, 2019 at 04:00:24PM -0400, Jason Merrill wrote: On 9/3/19 4:08 PM, Marek Polacek wrote: First constinit bug report (yay?). The problem is that while I made sure that constinit variable templates work as they should, I clearly neglected ord

Re: C++ PATCH for c++/91644 - ICE with constinit in function template

2019-09-04 Thread Marek Polacek
On Wed, Sep 04, 2019 at 04:00:24PM -0400, Jason Merrill wrote: > On 9/3/19 4:08 PM, Marek Polacek wrote: > > First constinit bug report (yay?). The problem is that while I made sure > > that constinit variable templates work as they should, I clearly neglected > > ordinary static variables declare

Re: C++ PATCH for c++/91644 - ICE with constinit in function template

2019-09-04 Thread Jason Merrill
On 9/3/19 4:08 PM, Marek Polacek wrote: First constinit bug report (yay?). The problem is that while I made sure that constinit variable templates work as they should, I clearly neglected ordinary static variables declared constinit in function templates. Hmm, right, locals don't get DECL_TEMP

C++ PATCH for c++/91644 - ICE with constinit in function template

2019-09-03 Thread Marek Polacek
First constinit bug report (yay?). The problem is that while I made sure that constinit variable templates work as they should, I clearly neglected ordinary static variables declared constinit in function templates. This was an ICE in cp_finish_decl when setting TINFO_VAR_DECLARED_CONSTINIT becau