Re: C++ PATCH for c++/89836 - bool constant expression and explicit conversions

2019-03-28 Thread Marek Polacek
On Thu, Mar 28, 2019 at 02:02:47PM -0400, Jason Merrill wrote: > On 3/27/19 3:08 PM, Marek Polacek wrote: > > I noticed that this test doesn't compile because > > build_converted_constant_expr > > failed to consider explicit conversion functions. That's wrong: while Core > > Issue 1981 specifies

Re: C++ PATCH for c++/89836 - bool constant expression and explicit conversions

2019-03-28 Thread Jason Merrill
On 3/27/19 3:08 PM, Marek Polacek wrote: I noticed that this test doesn't compile because build_converted_constant_expr failed to consider explicit conversion functions. That's wrong: while Core Issue 1981 specifies that explicit conversion functions are not considered for contextual conversions

C++ PATCH for c++/89836 - bool constant expression and explicit conversions

2019-03-27 Thread Marek Polacek
I noticed that this test doesn't compile because build_converted_constant_expr failed to consider explicit conversion functions. That's wrong: while Core Issue 1981 specifies that explicit conversion functions are not considered for contextual conversions, they are considered in contextual convers