Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-04-09 Thread Andreas Schwab
On Apr 08 2019, Marek Polacek wrote: > Thanks, committed. Andreas -- I hope the failure is fixed now. Yes, all tests of aggr-base[89].C are passing. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for som

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-04-08 Thread Marek Polacek
On Mon, Apr 08, 2019 at 03:24:13PM -0400, Jason Merrill wrote: > On 4/1/19 11:23 AM, Marek Polacek wrote: > > On Mon, Apr 01, 2019 at 10:15:11AM +0200, Andreas Schwab wrote: > > > On Mär 28 2019, Marek Polacek wrote: > > > > > > > Andreas, could you please find out why we're not hitting this code

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-04-08 Thread Jason Merrill
On 4/1/19 11:23 AM, Marek Polacek wrote: On Mon, Apr 01, 2019 at 10:15:11AM +0200, Andreas Schwab wrote: On Mär 28 2019, Marek Polacek wrote: Andreas, could you please find out why we're not hitting this code in digest_init_r: 1210 tree elt = CONSTRUCTOR_ELT (stripped_init, 0)->value;

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-04-08 Thread Marek Polacek
Any comments? On Mon, Apr 01, 2019 at 11:23:29AM -0400, Marek Polacek wrote: > On Mon, Apr 01, 2019 at 10:15:11AM +0200, Andreas Schwab wrote: > > On Mär 28 2019, Marek Polacek wrote: > > > > > Andreas, could you please find out why we're not hitting this code in > > > digest_init_r: > > > > > >

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-04-01 Thread Marek Polacek
On Mon, Apr 01, 2019 at 10:15:11AM +0200, Andreas Schwab wrote: > On Mär 28 2019, Marek Polacek wrote: > > > Andreas, could you please find out why we're not hitting this code in > > digest_init_r: > > > > 1210 tree elt = CONSTRUCTOR_ELT (stripped_init, 0)->value; > > 1211 if (referen

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-04-01 Thread Andreas Schwab
On Mär 28 2019, Marek Polacek wrote: > Andreas, could you please find out why we're not hitting this code in > digest_init_r: > > 1210 tree elt = CONSTRUCTOR_ELT (stripped_init, 0)->value; > 1211 if (reference_related_p (type, TREE_TYPE (elt))) This is never executed if flag_checking

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-28 Thread Marek Polacek
On Thu, Mar 28, 2019 at 01:30:46PM -0400, Jason Merrill wrote: > On 3/26/19 11:06 AM, Marek Polacek wrote: > > On Tue, Mar 26, 2019 at 12:34:03PM +0100, Andreas Schwab wrote: > > > I don't see any of the warnings in the tests on ia64. > > > > > > FAIL: g++.dg/cpp1z/aggr-base8.C -std=c++17 (test

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-28 Thread Jason Merrill
On 3/26/19 11:06 AM, Marek Polacek wrote: On Tue, Mar 26, 2019 at 12:34:03PM +0100, Andreas Schwab wrote: I don't see any of the warnings in the tests on ia64. FAIL: g++.dg/cpp1z/aggr-base8.C -std=c++17 (test for warnings, line 33) FAIL: g++.dg/cpp1z/aggr-base8.C -std=c++17 (test for warnin

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-26 Thread Marek Polacek
On Tue, Mar 26, 2019 at 12:34:03PM +0100, Andreas Schwab wrote: > I don't see any of the warnings in the tests on ia64. > > FAIL: g++.dg/cpp1z/aggr-base8.C -std=c++17 (test for warnings, line 33) > FAIL: g++.dg/cpp1z/aggr-base8.C -std=c++17 (test for warnings, line 34) > FAIL: g++.dg/cpp1z/agg

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-26 Thread Andreas Schwab
I don't see any of the warnings in the tests on ia64. FAIL: g++.dg/cpp1z/aggr-base8.C -std=c++17 (test for warnings, line 33) FAIL: g++.dg/cpp1z/aggr-base8.C -std=c++17 (test for warnings, line 34) FAIL: g++.dg/cpp1z/aggr-base8.C -std=c++17 (test for warnings, line 35) FAIL: g++.dg/cpp1z/agg

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-25 Thread Jason Merrill
On 3/25/19 12:02 PM, Marek Polacek wrote: On Fri, Mar 22, 2019 at 04:20:43PM -0400, Jason Merrill wrote: On 3/22/19 4:12 PM, Jason Merrill wrote: On 3/22/19 2:14 PM, Marek Polacek wrote: On Fri, Mar 22, 2019 at 10:48:32AM -0400, Jason Merrill wrote: +  B b10 = {{B{42}}}; +  B b11 = {{B{{42}

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-25 Thread Marek Polacek
On Fri, Mar 22, 2019 at 04:20:43PM -0400, Jason Merrill wrote: > On 3/22/19 4:12 PM, Jason Merrill wrote: > > On 3/22/19 2:14 PM, Marek Polacek wrote: > > > On Fri, Mar 22, 2019 at 10:48:32AM -0400, Jason Merrill wrote: > > > > > > > > +  B b10 = {{B{42}}}; > > > > > > +  B b11 = {{B{{42; > >

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-22 Thread Jason Merrill
On 3/22/19 4:12 PM, Jason Merrill wrote: On 3/22/19 2:14 PM, Marek Polacek wrote: On Fri, Mar 22, 2019 at 10:48:32AM -0400, Jason Merrill wrote: +  B b10 = {{B{42}}}; +  B b11 = {{B{{42; +  B b12 = {{B{{{42}; These look ill-formed to me: too many braces around the B value. Looks li

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-22 Thread Jason Merrill
On 3/22/19 2:14 PM, Marek Polacek wrote: On Fri, Mar 22, 2019 at 10:48:32AM -0400, Jason Merrill wrote: + B b10 = {{B{42}}}; + B b11 = {{B{{42; + B b12 = {{B{{{42}; These look ill-formed to me: too many braces around the B value. Looks like the original testcase had the same prob

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-22 Thread Marek Polacek
On Fri, Mar 22, 2019 at 10:48:32AM -0400, Jason Merrill wrote: > On 3/21/19 4:51 PM, Marek Polacek wrote: > > This is a crash in digest_init_r -- we encounter > > > >/* "If T is a class type and the initializer list has a single > > element of type cv U, where U is T or a class derived f

Re: C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-22 Thread Jason Merrill
On 3/21/19 4:51 PM, Marek Polacek wrote: This is a crash in digest_init_r -- we encounter /* "If T is a class type and the initializer list has a single element of type cv U, where U is T or a class derived from T, the object is initialized from that element." */ if (flag_chec

C++ PATCH for c++/89214 - ICE when initializing aggregates with bases

2019-03-21 Thread Marek Polacek
This is a crash in digest_init_r -- we encounter /* "If T is a class type and the initializer list has a single element of type cv U, where U is T or a class derived from T, the object is initialized from that element." */ if (flag_checking && cxx_dialect >= cxx11 && BRA