Re: C++ PATCH for c++/88830 - ICE with abstract class

2019-01-14 Thread Jason Merrill
On 1/14/19 10:41 AM, Marek Polacek wrote: On Mon, Jan 14, 2019 at 12:10:14PM +0100, Jakub Jelinek wrote: On Sun, Jan 13, 2019 at 09:07:00PM -0500, Marek Polacek wrote: diff --git gcc/cp/decl2.c gcc/cp/decl2.c index e4cf4e0a361..7b656712471 100644 --- gcc/cp/decl2.c +++ gcc/cp/decl2.c @@ -2229,7

Re: C++ PATCH for c++/88830 - ICE with abstract class

2019-01-14 Thread Marek Polacek
On Mon, Jan 14, 2019 at 12:10:14PM +0100, Jakub Jelinek wrote: > On Sun, Jan 13, 2019 at 09:07:00PM -0500, Marek Polacek wrote: > > diff --git gcc/cp/decl2.c gcc/cp/decl2.c > > index e4cf4e0a361..7b656712471 100644 > > --- gcc/cp/decl2.c > > +++ gcc/cp/decl2.c > > @@ -2229,7 +2229,8 @@ maybe_emit_v

Re: C++ PATCH for c++/88830 - ICE with abstract class

2019-01-14 Thread Jakub Jelinek
On Sun, Jan 13, 2019 at 09:07:00PM -0500, Marek Polacek wrote: > diff --git gcc/cp/decl2.c gcc/cp/decl2.c > index e4cf4e0a361..7b656712471 100644 > --- gcc/cp/decl2.c > +++ gcc/cp/decl2.c > @@ -2229,7 +2229,8 @@ maybe_emit_vtables (tree ctype) > never get generated. */ >if (CLASSTYPE_PUR

C++ PATCH for c++/88830 - ICE with abstract class

2019-01-13 Thread Marek Polacek
Here we were crashing because while the class C has a destructor, it hasn't yet been declared at this point in maybe_emit_vtables, so CLASSTYPE_DESTRUCTOR is null, so checking DECL_DEFAULTED_IN_CLASS_P crashed. Fixed by checking CLASSTYPE_LAZY_DESTRUCTOR first. Bootstrapped/regtested on x86_64-li