Re: C++ PATCH for c++/86094, wrong calling convention for move-only class

2018-06-15 Thread Jason Merrill
On Wed, Jun 13, 2018 at 5:05 PM, Jason Merrill wrote: > On Wed, Jun 13, 2018 at 4:12 PM, Jason Merrill wrote: >> On Mon, Jun 11, 2018 at 2:38 PM, Jason Merrill wrote: >>> The fix for 80178 was broken, because I forgot that copy_fn_p is false >>> for move constructors. As a result, the calling c

Re: C++ PATCH for c++/86094, wrong calling convention for move-only class

2018-06-13 Thread Jason Merrill
On Wed, Jun 13, 2018 at 5:08 PM, Jakub Jelinek wrote: > > On Wed, Jun 13, 2018 at 04:12:25PM -0400, Jason Merrill wrote: > > On Mon, Jun 11, 2018 at 2:38 PM, Jason Merrill wrote: > > > The fix for 80178 was broken, because I forgot that copy_fn_p is false > > > for move constructors. As a result

Re: C++ PATCH for c++/86094, wrong calling convention for move-only class

2018-06-13 Thread Jakub Jelinek
On Wed, Jun 13, 2018 at 04:12:25PM -0400, Jason Merrill wrote: > On Mon, Jun 11, 2018 at 2:38 PM, Jason Merrill wrote: > > The fix for 80178 was broken, because I forgot that copy_fn_p is false > > for move constructors. As a result, the calling convention for a > > class with a trivial move cons

Re: C++ PATCH for c++/86094, wrong calling convention for move-only class

2018-06-13 Thread Jason Merrill
On Wed, Jun 13, 2018 at 4:12 PM, Jason Merrill wrote: > On Mon, Jun 11, 2018 at 2:38 PM, Jason Merrill wrote: >> The fix for 80178 was broken, because I forgot that copy_fn_p is false >> for move constructors. As a result, the calling convention for a >> class with a trivial move constructor and

Re: C++ PATCH for c++/86094, wrong calling convention for move-only class

2018-06-13 Thread Jason Merrill
On Mon, Jun 11, 2018 at 2:38 PM, Jason Merrill wrote: > The fix for 80178 was broken, because I forgot that copy_fn_p is false > for move constructors. As a result, the calling convention for a > class with a trivial move constructor and deleted copy constructor > changed inappropriately. This p

C++ PATCH for c++/86094, wrong calling convention for move-only class

2018-06-11 Thread Jason Merrill
The fix for 80178 was broken, because I forgot that copy_fn_p is false for move constructors. As a result, the calling convention for a class with a trivial move constructor and deleted copy constructor changed inappropriately. Tested x86_64-pc-linux-gnu, applying to trunk and 8. commit d6cc7705f