Re: C++ PATCH for c++/86063, ICE with attribute with pack expansion

2018-06-14 Thread Jason Merrill
On Thu, Jun 14, 2018 at 3:40 PM, Marek Polacek wrote: > On Thu, Jun 14, 2018 at 12:59:00PM -0400, Jason Merrill wrote: >> On Thu, Jun 14, 2018 at 12:51 PM, Marek Polacek wrote: >> > On Mon, Jun 11, 2018 at 03:00:04PM -0400, Jason Merrill wrote: >> >> On Wed, Jun 6, 2018 at 5:18 PM, Marek Polacek

Re: C++ PATCH for c++/86063, ICE with attribute with pack expansion

2018-06-14 Thread Marek Polacek
On Thu, Jun 14, 2018 at 12:59:00PM -0400, Jason Merrill wrote: > On Thu, Jun 14, 2018 at 12:51 PM, Marek Polacek wrote: > > On Mon, Jun 11, 2018 at 03:00:04PM -0400, Jason Merrill wrote: > >> On Wed, Jun 6, 2018 at 5:18 PM, Marek Polacek wrote: > >> > We crash on this testcase containing a bogus

Re: C++ PATCH for c++/86063, ICE with attribute with pack expansion

2018-06-14 Thread Jason Merrill
On Thu, Jun 14, 2018 at 12:51 PM, Marek Polacek wrote: > On Mon, Jun 11, 2018 at 03:00:04PM -0400, Jason Merrill wrote: >> On Wed, Jun 6, 2018 at 5:18 PM, Marek Polacek wrote: >> > We crash on this testcase containing a bogus attribute, because >> > cp_check_const_attributes accessed TREE_VALUE o

Re: C++ PATCH for c++/86063, ICE with attribute with pack expansion

2018-06-14 Thread Marek Polacek
On Mon, Jun 11, 2018 at 03:00:04PM -0400, Jason Merrill wrote: > On Wed, Jun 6, 2018 at 5:18 PM, Marek Polacek wrote: > > We crash on this testcase containing a bogus attribute, because > > cp_check_const_attributes accessed TREE_VALUE of a tree that happened to be > > expr_pack_expansion. Since

Re: C++ PATCH for c++/86063, ICE with attribute with pack expansion

2018-06-11 Thread Jason Merrill
On Wed, Jun 6, 2018 at 5:18 PM, Marek Polacek wrote: > We crash on this testcase containing a bogus attribute, because > cp_check_const_attributes accessed TREE_VALUE of a tree that happened to be > expr_pack_expansion. Since here we're merely trying to evaluate constexpr > arguments, I thought w

C++ PATCH for c++/86063, ICE with attribute with pack expansion

2018-06-06 Thread Marek Polacek
We crash on this testcase containing a bogus attribute, because cp_check_const_attributes accessed TREE_VALUE of a tree that happened to be expr_pack_expansion. Since here we're merely trying to evaluate constexpr arguments, I thought we could skip such bogus arguments. Bootstrapped/regtested on