Re: C++ PATCH for c++/79817 - attribute deprecated on namespace

2019-08-23 Thread Nathan Sidwell
On 8/23/19 5:27 PM, Jason Merrill wrote: On 8/23/19 11:55 AM, Marek Polacek wrote: Bootstrapped/regtested on x86_64-linux, ok for trunk? OK on Monday if Nathan doesn't have more comments before then. ok by me, thanks nathan -- Nathan Sidwell

Re: C++ PATCH for c++/79817 - attribute deprecated on namespace

2019-08-23 Thread Jason Merrill
On 8/23/19 11:55 AM, Marek Polacek wrote: On Thu, Aug 22, 2019 at 11:49:49AM -0700, Jason Merrill wrote: On Thu, Aug 22, 2019 at 11:01 AM Nathan Sidwell wrote: On 8/20/19 9:03 PM, Marek Polacek wrote: and in cp_parser_nested_name_specifier_opt we simply don't know if we're dealing with a fu

Re: C++ PATCH for c++/79817 - attribute deprecated on namespace

2019-08-23 Thread Marek Polacek
On Thu, Aug 22, 2019 at 11:49:49AM -0700, Jason Merrill wrote: > On Thu, Aug 22, 2019 at 11:01 AM Nathan Sidwell wrote: > > > > On 8/20/19 9:03 PM, Marek Polacek wrote: > > > > > and in cp_parser_nested_name_specifier_opt we simply don't know if we're > > > dealing with a function decl. Calling c

Re: C++ PATCH for c++/79817 - attribute deprecated on namespace

2019-08-22 Thread Jason Merrill
On Thu, Aug 22, 2019 at 11:01 AM Nathan Sidwell wrote: > > On 8/20/19 9:03 PM, Marek Polacek wrote: > > > and in cp_parser_nested_name_specifier_opt we simply don't know if we're > > dealing with a function decl. Calling cp_warn_deprecated_use_scopes from > > cp_parser_type_specifier resulted int

Re: C++ PATCH for c++/79817 - attribute deprecated on namespace

2019-08-22 Thread Nathan Sidwell
On 8/20/19 9:03 PM, Marek Polacek wrote: and in cp_parser_nested_name_specifier_opt we simply don't know if we're dealing with a function decl. Calling cp_warn_deprecated_use_scopes from cp_parser_type_specifier resulted int duplicated diagnostics so that one is out too. So I did the following

C++ PATCH for c++/79817 - attribute deprecated on namespace

2019-08-20 Thread Marek Polacek
This PR complains that we are not handling the attribute deprecated on namespaces. This has gotten more important now because of ranges-v3 which renamed its "view" namespace to "views", following the PascalCase to snake_case change, and "view" is now deprecated. Unfortunately we can't just call c