Re: C++ PATCH for c++/63201 (member variable template specialization)

2014-09-12 Thread Ville Voutilainen
On 12 September 2014 17:41, Jason Merrill wrote: > On 09/12/2014 02:06 AM, Ville Voutilainen wrote: >> >> I'd expect you want to remove the dg-bogus directives from the test, >> and the "// odd diagnostic" comment too? > They aren't necessary, but they give information about former bugs that the >

Re: C++ PATCH for c++/63201 (member variable template specialization)

2014-09-12 Thread Jason Merrill
On 09/12/2014 02:06 AM, Ville Voutilainen wrote: I'd expect you want to remove the dg-bogus directives from the test, and the "// odd diagnostic" comment too? They aren't necessary, but they give information about former bugs that the test found, so I'm inclined to leave them in. Jason

Re: C++ PATCH for c++/63201 (member variable template specialization)

2014-09-11 Thread Ville Voutilainen
On 12 September 2014 05:05, Jason Merrill wrote: > Basically all we need to do here is accept it, like check_classfn; all the > necessary checking was already done in check_explicit_specialization. > > Tested x86_64-pc-linux-gnu, applying to trunk. I'd expect you want to remove the dg-bogus direc

C++ PATCH for c++/63201 (member variable template specialization)

2014-09-11 Thread Jason Merrill
Basically all we need to do here is accept it, like check_classfn; all the necessary checking was already done in check_explicit_specialization. Tested x86_64-pc-linux-gnu, applying to trunk. commit f0ef26fb06fe5798cd7bb071a932a21cf5e5a878 Author: Jason Merrill Date: Thu Sep 11 16:45:47 2014