Re: Better memory statistics, take 2

2021-08-18 Thread Richard Biener via Gcc-patches
On Tue, Aug 17, 2021 at 9:31 PM Thomas Schwinge wrote: > > Hi! > > On 2021-08-17T09:27:46-0400, David Malcolm via Gcc-patches > wrote: > > On Tue, 2021-08-17 at 11:17 +0200, Thomas Schwinge wrote: > >> "Turn > >> global 'ggc_force_collect' variable into 'force_collect' parameter to > >> 'ggc_col

Re: Better memory statistics, take 2

2021-08-17 Thread Thomas Schwinge
Hi! On 2021-08-17T09:27:46-0400, David Malcolm via Gcc-patches wrote: > On Tue, 2021-08-17 at 11:17 +0200, Thomas Schwinge wrote: >> "Turn >> global 'ggc_force_collect' variable into 'force_collect' parameter to >> 'ggc_collect'" > Looks good to me, but bool params can be unclear - maybe introd

Re: Better memory statistics, take 2

2021-08-17 Thread David Malcolm via Gcc-patches
On Tue, 2021-08-17 at 11:17 +0200, Thomas Schwinge wrote: > Hi! > > On 2004-09-02T18:47:01+0200, Jan Hubicka wrote: > > *** ggc-common.c  9 Aug 2004 20:19:29 -   1.88 > > --- ggc-common.c  2 Sep 2004 16:08:50 - > > > + /* When set, ggc_collect will do collection.  */ > > + bo

Re: Better memory statistics, take 2

2021-08-17 Thread Richard Biener via Gcc-patches
On Tue, Aug 17, 2021 at 11:18 AM Thomas Schwinge wrote: > > Hi! > > On 2004-09-02T18:47:01+0200, Jan Hubicka wrote: > > *** ggc-common.c 9 Aug 2004 20:19:29 - 1.88 > > --- ggc-common.c 2 Sep 2004 16:08:50 - > > > + /* When set, ggc_collect will do collection. */ > > + boo

Re: Better memory statistics, take 2

2021-08-17 Thread Thomas Schwinge
47:02 +0200 Subject: [PATCH] Turn global 'ggc_force_collect' variable into 'force_collect' parameter to 'ggc_collect' This simplifies the interface and gets us rid of a global variable. No change in behavior. Clean-up for 2004-09-02 CVS commit (Subversion r86974, Git