Re: Allow redefinition of libcilkrts debug macros

2016-05-03 Thread Rainer Orth
Hi Balaji, > I suspected that much. It would be good to have a libcilkrts/README.gcc > describing the rules which changes can go into the gcc tree directly, which > need to go upstream first, and how. libo and libsanitizer already have > this. > > Hi Rainer, > It is mentioned under the "CO

Re: Allow redefinition of libcilkrts debug macros

2016-05-03 Thread Rainer Orth
Hi Ilya, > On Fri, Apr 29, 2016 at 10:58:25 +0200, Rainer Orth wrote: >> > On 04/26/2016 08:04 AM, Rainer Orth wrote: >> >> When working on a couple of Cilk Plus issues lately (PRs target/60290, >> >> target/68945), I noticed that you have to modify the libcilkplus sources >> >> to enable various

Re: Allow redefinition of libcilkrts debug macros

2016-04-29 Thread Jeff Law
On 04/29/2016 02:58 AM, Rainer Orth wrote: Having a listed libcilkrts maintainer would probably help, too ;-) That's high on my list to make happen :-) Until then Ilya Verbin and I will work together the Cilk runtime. jeff

RE: Allow redefinition of libcilkrts debug macros

2016-04-29 Thread Iyer, Balaji V
I suspected that much. It would be good to have a libcilkrts/README.gcc describing the rules which changes can go into the gcc tree directly, which need to go upstream first, and how. libo and libsanitizer already have this. Hi Rainer, It is mentioned under the "CONTRIBUTIONS" sections

Re: Allow redefinition of libcilkrts debug macros

2016-04-29 Thread Rainer Orth
Hi Ilya, >> >> 2016-04-07 Rainer Orth >> >> >> >> * runtime/except-gcc.cpp (DEBUG_EXCEPTIONS): Allow redefinition. >> >> * runtime/cilk_fiber.h (FIBER_DEBUG): Likewise. >> >> * runtime/scheduler.h (REDPAR_DEBUG): Likewise. >> > Ilya will have to chime in here -- we're a downstream consume

Re: Allow redefinition of libcilkrts debug macros

2016-04-29 Thread Ilya Verbin
Hi Rainer! On Fri, Apr 29, 2016 at 10:58:25 +0200, Rainer Orth wrote: > > On 04/26/2016 08:04 AM, Rainer Orth wrote: > >> When working on a couple of Cilk Plus issues lately (PRs target/60290, > >> target/68945), I noticed that you have to modify the libcilkplus sources > >> to enable various debu

Re: Allow redefinition of libcilkrts debug macros

2016-04-29 Thread Rainer Orth
Hi Jeff, > On 04/26/2016 08:04 AM, Rainer Orth wrote: >> When working on a couple of Cilk Plus issues lately (PRs target/60290, >> target/68945), I noticed that you have to modify the libcilkplus sources >> to enable various debugging output. This seems silly, and the following >> patch allows de

Re: Allow redefinition of libcilkrts debug macros

2016-04-26 Thread Jeff Law
On 04/26/2016 08:04 AM, Rainer Orth wrote: When working on a couple of Cilk Plus issues lately (PRs target/60290, target/68945), I noticed that you have to modify the libcilkplus sources to enable various debugging output. This seems silly, and the following patch allows defining them from the c

Allow redefinition of libcilkrts debug macros

2016-04-26 Thread Rainer Orth
# Parent 072a0724a080e27be15d001b8507af7a2490d73d Allow redefinition of libcilkrts debug macros diff --git a/libcilkrts/runtime/cilk_fiber.h b/libcilkrts/runtime/cilk_fiber.h --- a/libcilkrts/runtime/cilk_fiber.h +++ b/libcilkrts/runtime/cilk_fiber.h @@ -63,7 +63,9 @@ * A value of 0 means no