Re: Add dg-require-wchars to libstdc++ testsuite

2021-10-09 Thread Jonathan Wakely via Gcc-patches
On Fri, 15 Jan 2021, 19:47 Jonathan Wakely, wrote: > > > On Fri, 15 Jan 2021, 16:19 Alexandre Oliva, wrote: > >> On Jan 15, 2021, Jonathan Wakely wrote: >> >> > On Thu, 14 Jan 2021, 22:22 Alexandre Oliva, wrote: >> >> ... it is definitely the case that the target currently defines >> wchar_t,

Re: Add dg-require-wchars to libstdc++ testsuite

2021-01-15 Thread Jonathan Wakely via Gcc-patches
On Fri, 15 Jan 2021, 16:19 Alexandre Oliva, wrote: > On Jan 15, 2021, Jonathan Wakely wrote: > > > On Thu, 14 Jan 2021, 22:22 Alexandre Oliva, wrote: > >> ... it is definitely the case that the target currently defines wchar_t, > >> and it even offers wchar.h and a lot of (maybe all?) wcs* func

Re: Add dg-require-wchars to libstdc++ testsuite

2021-01-15 Thread Alexandre Oliva
On Jan 15, 2021, Jonathan Wakely wrote: > On Thu, 14 Jan 2021, 22:22 Alexandre Oliva, wrote: >> ... it is definitely the case that the target currently defines wchar_t, >> and it even offers wchar.h and a lot of (maybe all?) wcs* functions. >> This was likely not the case when the patch was firs

Re: Add dg-require-wchars to libstdc++ testsuite

2021-01-15 Thread Jonathan Wakely via Gcc-patches
On Thu, 14 Jan 2021, 22:22 Alexandre Oliva, wrote: > On Jan 14, 2021, Jonathan Wakely wrote: > > > The problem is that uses wchar_t in default > > template arguments: > > > I think we should fix the header, not disable tests that don't use > > that default template argument. The attached patch

Re: Add dg-require-wchars to libstdc++ testsuite

2021-01-14 Thread Alexandre Oliva
On Jan 14, 2021, Jonathan Wakely wrote: > The problem is that uses wchar_t in default > template arguments: > I think we should fix the header, not disable tests that don't use > that default template argument. The attached patch should allow you to > use wstring_convert and wbuffer_convert wit

Re: Add dg-require-wchars to libstdc++ testsuite#

2021-01-14 Thread Jonathan Wakely via Gcc-patches
On 14/01/21 13:41 +, Jonathan Wakely wrote: Is it the case that the wchar_t type is defined on this target, it's just that libc doesn't have support for wcslen etc? Because we should probably audit all our uses of _GLIBCXX_USE_WCHAR_T and find which ones actually need libc support and which

Re: Add dg-require-wchars to libstdc++ testsuite

2021-01-14 Thread Jonathan Wakely via Gcc-patches
On 22/12/20 18:12 -0300, Alexandre Oliva wrote: --- a/libstdc++-v3/testsuite/22_locale/codecvt/codecvt_utf16/79980.cc +++ b/libstdc++-v3/testsuite/22_locale/codecvt/codecvt_utf16/79980.cc @@ -16,6 +16,7 @@ // . // { dg-do run { target c++11 } } +// { dg-require-wcha

Re: Add dg-require-wchars to libstdc++ testsuite

2021-01-14 Thread Jonathan Wakely via Gcc-patches
On 13/01/21 14:29 -0300, Alexandre Oliva wrote: On Dec 28, 2020, François Dumont wrote: On 22/12/20 10:12 pm, Alexandre Oliva wrote: Some tests uses structures from the libstdc++ that are present only if the target has a wchar.h header. However, those tests do not check that the target supp

Re: Add dg-require-wchars to libstdc++ testsuite

2021-01-13 Thread Alexandre Oliva
On Dec 28, 2020, François Dumont wrote: > On 22/12/20 10:12 pm, Alexandre Oliva wrote: >> Some tests uses structures from the libstdc++ that are present only if >> the target has a wchar.h header. However, those tests do not check >> that the target supports those constructs before executing the

Re: Add dg-require-wchars to libstdc++ testsuite

2020-12-28 Thread François Dumont via Gcc-patches
On 22/12/20 10:12 pm, Alexandre Oliva wrote: Some tests uses structures from the libstdc++ that are present only if the target has a wchar.h header. However, those tests do not check that the target supports those constructs before executing the tests. Like you already spotted in another threa

Re: Add dg-require-wchars to libstdc++ testsuite

2020-12-28 Thread François Dumont via Gcc-patches
On 22/12/20 10:12 pm, Alexandre Oliva wrote: Some tests uses structures from the libstdc++ that are present only if the target has a wchar.h header. However, those tests do not check that the target supports those constructs before executing the tests. Looks like those tests should be in some

Add dg-require-wchars to libstdc++ testsuite

2020-12-22 Thread Alexandre Oliva
Some tests uses structures from the libstdc++ that are present only if the target has a wchar.h header. However, those tests do not check that the target supports those constructs before executing the tests. The function dg-require-wchars checks that "_GLIBCXX_USE_WCHAR_T" is defined by the con