Re: [PATCH] Add cold attribute to one time construction APIs

2020-08-24 Thread Jonathan Wakely via Gcc-patches
ch list as separate emails. > >``` >From c6cba40e0434147db89d3af05b598782cde651e3 Mon Sep 17 00:00:00 2001 >From: Aditya Kumar <1894981+hiradi...@users.noreply.github.com> >Date: Thu, 13 Aug 2020 09:41:34 -0700 >Subject: [PATCH] Add cold attribute to one time construction A

Re: [PATCH] Add cold attribute to one time construction APIs

2020-08-24 Thread Jonathan Wakely via Gcc-patches
me email. Not sent once to each list as > separate emails. > > > > >``` > >From c6cba40e0434147db89d3af05b598782cde651e3 Mon Sep 17 00:00:00 2001 > >From: Aditya Kumar <1894981+hiradi...@users.noreply.github.com> > >Date: Thu, 13 Aug 2020 09:41:34 -0700 >

Re: [PATCH] Add cold attribute to one time construction APIs

2020-08-24 Thread Jan Hubicka
++ need to go to both the libstdc++ list and the > > gcc-patches list, in the same email. Not sent once to each list as > > separate emails. > > > > > > > >``` > > >From c6cba40e0434147db89d3af05b598782cde651e3 Mon Sep 17 00:00:00 2001 > > >From: Aditya Kumar <1894

Re: [PATCH] Add cold attribute to one time construction APIs

2020-08-24 Thread Richard Biener via Gcc-patches
separate emails. > > > > >``` > >From c6cba40e0434147db89d3af05b598782cde651e3 Mon Sep 17 00:00:00 2001 > >From: Aditya Kumar <1894981+hiradi...@users.noreply.github.com> > >Date: Thu, 13 Aug 2020 09:41:34 -0700 > >Subject: [PATCH] Add cold attribute

Re: [PATCH] Add cold attribute to one time construction APIs

2020-08-18 Thread Jonathan Wakely via Gcc-patches
894981+hiradi...@users.noreply.github.com> Date: Thu, 13 Aug 2020 09:41:34 -0700 Subject: [PATCH] Add cold attribute to one time construction APIs __cxa_guard_acquire is used for only one purpose, namely guarding local static variable initialization, and since that purpose is definitionally cold, it should

Re: [PATCH] Add cold attribute to one time construction APIs

2020-08-18 Thread Jonathan Wakely via Gcc-patches
ug 2020 09:41:34 -0700 Subject: [PATCH] Add cold attribute to one time construction APIs __cxa_guard_acquire is used for only one purpose, namely guarding local static variable initialization, and since that purpose is definitionally cold, it should be attributed as cold. Definitionally isn't

Re: Add cold attribute to one time construction APIs

2020-08-13 Thread Aditya K via Gcc-patches
sure. -- From: Jonathan Wakely Sent: Thursday, August 13, 2020 11:13 AM To: Aditya K Cc: libstdc++ ; gcc-patches Subject: Re: Add cold attribute to one time construction APIs   Please CC the libstdc++ list on all libstdc++ patches. On Thu, 13 Aug 2020 at 17:51, Aditya K wrote: > > R

Re: Add cold attribute to one time construction APIs

2020-08-13 Thread Jonathan Wakely via Gcc-patches
ub.com> > Date: Thu Aug 13 09:41:34 2020 -0700 > > Add cold attribute to one time construction APIs > > __cxa_guard_acquire is used for only one purpose, > namely guarding local static variable initialization, > and since that purpose is definition

Re: Add cold attribute to one time construction APIs

2020-08-13 Thread Aditya K via Gcc-patches
FYI libc++ patch sent for review: https://reviews.llvm.org/D85873

Re: Add cold attribute to one time construction APIs

2020-08-13 Thread Aditya K via Gcc-patches
Revised patch with _GLIBCXX_COLD added at the end. ``` commit 3dc9f9a8461b1c88e991ceb517e5fdd81f268d1e Author: Aditya Kumar <1894981+hiradi...@users.noreply.github.com> Date: Thu Aug 13 09:41:34 2020 -0700 Add cold attribute to one time construction APIs __cxa_guard_acqu

Add cold attribute to one time construction APIs

2020-08-13 Thread Aditya K via Gcc-patches
This would help compiler optimize local static objects. ``` commit e2f299679ddf56a6d6d71ea9d589cd76b2ca107b Author: Aditya Kumar <1894981+hiradi...@users.noreply.github.com> Date: Thu Aug 13 09:41:34 2020 -0700 Add cold attribute to one time construction APIs __cxa_guard_a