Re: .cfi in sanitizer code

2013-12-05 Thread Konstantin Serebryany
On Thu, Dec 5, 2013 at 12:18 PM, Jakub Jelinek wrote: > On Thu, Dec 05, 2013 at 11:51:12AM +0400, Konstantin Serebryany wrote: >> Committed upstream: >> http://llvm.org/viewvc/llvm-project?view=revision&revision=196480 > > LGTM, can we commit it after the merge you have already prepared, or do you

Re: .cfi in sanitizer code

2013-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2013 at 11:51:12AM +0400, Konstantin Serebryany wrote: > Committed upstream: > http://llvm.org/viewvc/llvm-project?view=revision&revision=196480 LGTM, can we commit it after the merge you have already prepared, or do you want to do another merge for it? Alternatively, rather than

Re: .cfi in sanitizer code

2013-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2013 at 11:39:17AM +0400, Konstantin Serebryany wrote: > On Wed, Dec 4, 2013 at 6:16 PM, Jakub Jelinek wrote: > > On Wed, Dec 04, 2013 at 06:09:56PM +0400, Konstantin Serebryany wrote: > >> This is a maintenance problem because we can not test if we broke > >> something during deve

Re: .cfi in sanitizer code

2013-12-04 Thread Konstantin Serebryany
Committed upstream: http://llvm.org/viewvc/llvm-project?view=revision&revision=196480 On Thu, Dec 5, 2013 at 11:39 AM, Konstantin Serebryany wrote: > On Wed, Dec 4, 2013 at 6:16 PM, Jakub Jelinek wrote: >> On Wed, Dec 04, 2013 at 06:09:56PM +0400, Konstantin Serebryany wrote: >>> This is a maint

Re: .cfi in sanitizer code

2013-12-04 Thread Konstantin Serebryany
On Wed, Dec 4, 2013 at 6:16 PM, Jakub Jelinek wrote: > On Wed, Dec 04, 2013 at 06:09:56PM +0400, Konstantin Serebryany wrote: >> This is a maintenance problem because we can not test if we broke >> something during development. >> e.g. clang doesn't seem to support -fno-dwarf2-cfi-asm > > It does,

Re: .cfi in sanitizer code

2013-12-04 Thread Jakub Jelinek
On Wed, Dec 04, 2013 at 06:09:56PM +0400, Konstantin Serebryany wrote: > This is a maintenance problem because we can not test if we broke > something during development. > e.g. clang doesn't seem to support -fno-dwarf2-cfi-asm It does, at least both clang 3.3 (from Fedora 19) and clang 3.4 r19468

.cfi in sanitizer code

2013-12-04 Thread Konstantin Serebryany
[new subject. was: libsanitizer merge from upstream r196090] >> .cfi is used only in tsan sources now, and tsan is not supported >> anywhere but x86_64 > > But the .cfi_* issue is platform independent. Whether the compiler > decides to emit them or not depends on how it was configured, on assembl