Re: [v3 PATCH] Implement C++17 string searchers.

2016-09-12 Thread Jonathan Wakely
On 12/09/16 18:55 +0300, Ville Voutilainen wrote: On 12 September 2016 at 18:49, Jonathan Wakely wrote: Is there a reason I didn't use an alias template or variable template here? template using __is_std_equal_to = is_same, _Pred>; That avoids defining a new class template. I don't kno

Re: [v3 PATCH] Implement C++17 string searchers.

2016-09-12 Thread Ville Voutilainen
On 12 September 2016 at 18:49, Jonathan Wakely wrote: >>> Is there a reason I didn't use an alias template or variable template >>> here? >>> >>> template >>>using __is_std_equal_to = is_same, _Pred>; >>> >>> That avoids defining a new class template. >> >> >> I don't know whether that's a pr

Re: [v3 PATCH] Implement C++17 string searchers.

2016-09-12 Thread Ville Voutilainen
On 12 September 2016 at 18:30, Jonathan Wakely wrote: > On 12 September 2016 at 12:00, Ville Voutilainen wrote: >> I didn't change any of those parts in the patch, I intentionally >> avoided such changes. > > OK. I wrote a more detailed reply that will have to wait until I have > better network co

Re: [v3 PATCH] Implement C++17 string searchers.

2016-09-12 Thread Jonathan Wakely
On 12/09/16 14:00 +0300, Ville Voutilainen wrote: On 12 September 2016 at 13:41, Jonathan Wakely wrote: + template +struct __is_std_equal_to : std::false_type { }; + + template<> +struct __is_std_equal_to> : std::true_type { }; Is there a reason I didn't use an alias template or va

Re: [v3 PATCH] Implement C++17 string searchers.

2016-09-12 Thread Jonathan Wakely
On 12 September 2016 at 12:00, Ville Voutilainen wrote: > I didn't change any of those parts in the patch, I intentionally > avoided such changes. OK. I wrote a more detailed reply that will have to wait until I have better network connectivity, but the short version is patch approved for trunk wi

Re: [v3 PATCH] Implement C++17 string searchers.

2016-09-12 Thread Ville Voutilainen
On 12 September 2016 at 13:41, Jonathan Wakely wrote: >> + template >> +struct __is_std_equal_to : std::false_type { }; >> + >> + template<> >> +struct __is_std_equal_to> : std::true_type { }; > > > Is there a reason I didn't use an alias template or variable template here? > > template

Re: [v3 PATCH] Implement C++17 string searchers.

2016-09-12 Thread Jonathan Wakely
On 12/09/16 02:48 +0300, Ville Voutilainen wrote: The first patch just transforms the TS version into an std one, the second patch makes it conform by implementing P0253R1. I haven't added any tests for the pair-seconds of the new api, and I noticed that we might want to go through our make_pairs

[v3 PATCH] Implement C++17 string searchers.

2016-09-11 Thread Ville Voutilainen
The first patch just transforms the TS version into an std one, the second patch makes it conform by implementing P0253R1. I haven't added any tests for the pair-seconds of the new api, and I noticed that we might want to go through our make_pairs and make_tuples and qualify them throughout the lib