Re: [v3] Fix management of non empty hash functor

2013-01-28 Thread Jonathan Wakely
On 28 January 2013 21:08, François Dumont wrote: >> >> (Do the performance benchmarks actually tell us anything useful? >> When I run them I get such varying results it doesn't seem to be >> reliable.) > > Last time I run the tests it was showing when not caching was better than > caching. Yes, I'

Re: [v3] Fix management of non empty hash functor

2013-01-28 Thread François Dumont
Attached patch applied. 2013-01-28 François Dumont * include/bits/hashtable_policy.h (_Local_iterator_base): Use _Hashtable_ebo_helper to embed functors into the local_iterator when necessary. Pass information about functors involved in hash code by copy. * include/bits/ha

Re: [v3] Fix management of non empty hash functor

2013-01-28 Thread Jonathan Wakely
On 10 January 2013 21:02, François Dumont wrote: > Hi > > Here is an other version of this patch. Indeed there were no need to > expose many stuff public. Inheriting from _Hash_code_base is fine, it is not > final and it deals with EBO itself. I only kept usage of > _Hashtable_ebo_helper when e

Re: [v3] Fix management of non empty hash functor

2013-01-10 Thread François Dumont
Hi Here is an other version of this patch. Indeed there were no need to expose many stuff public. Inheriting from _Hash_code_base is fine, it is not final and it deals with EBO itself. I only kept usage of _Hashtable_ebo_helper when embedding H2 functor. As it is an extension we could hav

[v3] Fix management of non empty hash functor

2012-12-13 Thread François Dumont
Hi As part of a performance patch proposed in an other mailing thread was a patch to improve management of hash functor with state. This part is I think less sensible than the performance patch so I propose it independently. I only would like to commit the modification on the performance