Re: [trans-mem] Explicitly go irrevocable even if transaction will always go irrevocable.

2011-10-29 Thread Torvald Riegel
On Fri, 2011-10-28 at 07:53 -0500, Aldy Hernandez wrote: > > diff --git a/gcc/testsuite/gcc.dg/tm/memopt-1.c > > b/gcc/testsuite/gcc.dg/tm/memopt-1.c > > index 06d4f64..9a48dcb 100644 > > --- a/gcc/testsuite/gcc.dg/tm/memopt-1.c > > +++ b/gcc/testsuite/gcc.dg/tm/memopt-1.c > > @@ -2,8 +2,8 @@ > >

Re: [trans-mem] Explicitly go irrevocable even if transaction will always go irrevocable.

2011-10-28 Thread Patrick Marlier
On 10/28/2011 08:53 AM, Aldy Hernandez wrote: If the original test was not wrong, you need to add a new test (and bonus points for finding out why this test is currently failing :)). long g, xxx, yyy; /* { dg-final { scan-tree-dump-times "transforming: .*_ITM_RaWU8 \\(&g\\);" 1 "tmmemopt" } }

Re: [trans-mem] Explicitly go irrevocable even if transaction will always go irrevocable.

2011-10-28 Thread Aldy Hernandez
diff --git a/gcc/testsuite/gcc.dg/tm/memopt-1.c b/gcc/testsuite/gcc.dg/tm/memopt-1.c index 06d4f64..9a48dcb 100644 --- a/gcc/testsuite/gcc.dg/tm/memopt-1.c +++ b/gcc/testsuite/gcc.dg/tm/memopt-1.c @@ -2,8 +2,8 @@ /* { dg-options "-fgnu-tm -O -fdump-tree-tmmemopt" } */ long g, xxx, yyy; -exte

[trans-mem] Explicitly go irrevocable even if transaction will always go irrevocable.

2011-10-28 Thread Torvald Riegel
The ABI does not require a TM runtime library to immediately start a transaction in irrevocable mode if the beginTransaction flag "doesGoIrrevocable" is set. This patch fixes this by inserting a call to changeTransactionMode(0) into the entry block of all transactions that always go irrevocable eve