Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-15 Thread Ramana Radhakrishnan
> The patch isn't suitable as is.  If -PIE requires -fPIC, then anything that > adds it or tortures on it, should add both, or torture on both. The ABS relocs that I mentioned were from testglue.o which isn't built PIE or PIC and that's the reason for the failures to show up. Maybe the right solu

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-15 Thread Mike Stump
On Jun 15, 2011, at 9:06 AM, Ramana Radhakrishnan wrote: >> After it has been determined how to check for PIE support, I'm checking >> this in. > > I haven't bisected it and not investigated failures in detail because > I'm about to walk out of the door. This patch might have broken > testing with

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-15 Thread Ramana Radhakrishnan
> > After it has been determined how to check for PIE support, I'm checking > this in. I haven't bisected it and not investigated failures in detail because I'm about to walk out of the door. This patch might have broken testing with arm-linux-gnueabi cross with defaults set to v7-a. ( configured

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-10 Thread Rainer Orth
Rainer Orth writes: > As suggested by Joseph, the gcc.dg/torture/tls tests should be run with > -fpic/-fPIC and -fpie/-fPIE if supported. > > The patch below implements part of this. Unlike > gcc.dg/torture/stackalign/stackalign.exp, I'm using the code below to > add -fpic etc. to the torture op

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-10 Thread Rainer Orth
"Joseph S. Myers" writes: > On Fri, 10 Jun 2011, Rainer Orth wrote: > >> Jakub Jelinek writes: >> >> > On Tue, Jun 07, 2011 at 06:48:08PM +0200, Rainer Orth wrote: >> >> any word on this patch? I think I only need approval for the gcc.c >> > >> > I'm not a maintainer of gcc.c, and I think it

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-10 Thread Joseph S. Myers
On Fri, 10 Jun 2011, Rainer Orth wrote: > Jakub Jelinek writes: > > > On Tue, Jun 07, 2011 at 06:48:08PM +0200, Rainer Orth wrote: > >> any word on this patch? I think I only need approval for the gcc.c > > > > I'm not a maintainer of gcc.c, and I think it is a bad idea. > > PIE is just a (sli

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-10 Thread Rainer Orth
Jakub Jelinek writes: > On Tue, Jun 07, 2011 at 06:48:08PM +0200, Rainer Orth wrote: >> any word on this patch? I think I only need approval for the gcc.c > > I'm not a maintainer of gcc.c, and I think it is a bad idea. > PIE is just a (slightly) more secure form of an executable, therefore > i

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-07 Thread Rainer Orth
Jakub Jelinek writes: > On Tue, Jun 07, 2011 at 06:48:08PM +0200, Rainer Orth wrote: >> any word on this patch? I think I only need approval for the gcc.c > > I'm not a maintainer of gcc.c, and I think it is a bad idea. > PIE is just a (slightly) more secure form of an executable, therefore > i

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-07 Thread Jakub Jelinek
On Tue, Jun 07, 2011 at 06:48:08PM +0200, Rainer Orth wrote: > any word on this patch? I think I only need approval for the gcc.c I'm not a maintainer of gcc.c, and I think it is a bad idea. PIE is just a (slightly) more secure form of an executable, therefore if a target doesn't support positio

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-07 Thread Rainer Orth
Jakub, any word on this patch? I think I only need approval for the gcc.c part. Thanks. Rainer Rainer Orth writes: > Jakub Jelinek writes: > >> On Fri, Jun 03, 2011 at 09:38:31PM +0200, Rainer Orth wrote: >>> Rainer Orth writes: >>> Jakub, any suggestion how to properly test for -

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-06 Thread Rainer Orth
Jakub Jelinek writes: > On Fri, Jun 03, 2011 at 09:38:31PM +0200, Rainer Orth wrote: >> Rainer Orth writes: >> Jakub, any suggestion how to properly test for -fpie/-fPIE support? >> Otherwise, I'll remove that part of the patch for now and just commit >> the -fpic/-fPIC one. > > You want to comp

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-03 Thread Jakub Jelinek
On Fri, Jun 03, 2011 at 09:38:31PM +0200, Rainer Orth wrote: > Rainer Orth writes: > Jakub, any suggestion how to properly test for -fpie/-fPIE support? > Otherwise, I'll remove that part of the patch for now and just commit > the -fpic/-fPIC one. You want to compile/link the program with -pie -f

Re: [testsuite] Run TLS torture tests with -fpic etc.

2011-06-03 Thread Rainer Orth
Rainer Orth writes: > As suggested by Joseph, the gcc.dg/torture/tls tests should be run with > -fpic/-fPIC and -fpie/-fPIE if supported. > > The patch below implements part of this. Unlike > gcc.dg/torture/stackalign/stackalign.exp, I'm using the code below to > add -fpic etc. to the torture op

[testsuite] Run TLS torture tests with -fpic etc.

2011-05-30 Thread Rainer Orth
As suggested by Joseph, the gcc.dg/torture/tls tests should be run with -fpic/-fPIC and -fpie/-fPIE if supported. The patch below implements part of this. Unlike gcc.dg/torture/stackalign/stackalign.exp, I'm using the code below to add -fpic etc. to the torture options so it shows up in gcc.sum.