Re: [rs6000] Improve FP comparisons with -fno-trapping-math

2013-05-31 Thread David Edelsohn
On Fri, May 31, 2013 at 7:04 AM, Eric Botcazou wrote: >> I'm okay with most of the change, but I have a question: What happened >> to the unsigned comparisons and LTGT? > > Unsigned comparisons aren't used for FP (the whole block of code is dominated > by a FLOAT_MODE_P (mode) test). LTGT and UNE

Re: [rs6000] Improve FP comparisons with -fno-trapping-math

2013-05-31 Thread Eric Botcazou
> I'm okay with most of the change, but I have a question: What happened > to the unsigned comparisons and LTGT? Unsigned comparisons aren't used for FP (the whole block of code is dominated by a FLOAT_MODE_P (mode) test). LTGT and UNEQ were wrong (but unused) since they were implemented as NE

Re: [rs6000] Improve FP comparisons with -fno-trapping-math

2013-05-29 Thread David Edelsohn
* config/rs6000/predicates.md (rs6000_cbranch_operator): Accept some unordered comparison operators when -fno-trapping-math is in effect on the e500. * config/rs6000/rs6000.c (rs6000_generate_compare): Remove dead code and implement unordered comparison operators properly on the e500. I'm okay wit

[rs6000] Improve FP comparisons with -fno-trapping-math

2013-05-29 Thread Eric Botcazou
Hi, on most platforms the Ada compiler doesn't enable trap-on-FP-exceptions, so it's appropriate to set -fno-trapping-math there, which has been done in http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01461.html However doing so can have an adverse effect if the architecture doesn't have a suffi