Re: [regex, libstdc++/71500, patch] Fix icase on bracket expression

2016-06-13 Thread Jonathan Wakely
On 11/06/16 11:46 -0700, Tim Shen wrote: On Sat, Jun 11, 2016 at 5:01 AM, Jonathan Wakely wrote: N.B. The "typename" and "::type" are redundant here, because it names the same type as the integral_constant itself, and you could use __bool_constant<__collate> instead: return _M_transform

Re: [regex, libstdc++/71500, patch] Fix icase on bracket expression

2016-06-11 Thread Tim Shen
On Sat, Jun 11, 2016 at 5:01 AM, Jonathan Wakely wrote: > N.B. The "typename" and "::type" are redundant here, because it names > the same type as the integral_constant itself, and you could > use __bool_constant<__collate> instead: > > return _M_transform_impl(_M_translate(__ch), >

Re: [regex, libstdc++/71500, patch] Fix icase on bracket expression

2016-06-11 Thread Jonathan Wakely
On 11/06/16 00:53 -0700, Tim Shen wrote: diff --git a/libstdc++-v3/include/bits/regex_compiler.h b/libstdc++-v3/include/bits/regex_compiler.h index 410d61b..d545c04 100644 --- a/libstdc++-v3/include/bits/regex_compiler.h +++ b/libstdc++-v3/include/bits/regex_compiler.h @@ -235,8 +235,9 @@ _GLIBC

[regex, libstdc++/71500, patch] Fix icase on bracket expression

2016-06-11 Thread Tim Shen
Bootstrapped and tested on x86_64-pc-linux-gnu with debug macro. Thanks! -- Regards, Tim Shen commit b8e06b00162b9396e639f517d5cbde0cbd5932fc Author: Tim Shen Date: Sat Jun 11 00:41:09 2016 -0700 2016-06-11 Tim Shen PR libstdc++/71500 * include/bits/regex_compile