Re: [pph] Fix executable test detection (issue4635087)

2011-07-01 Thread gchare
I should add that this exposed two assembly comparison failures which slipped in a previous check-in when this problem was still up. Namely: FAIL: g++.dg/pph/x1dynarray0.cc (assembly comparison) FAIL: g++.dg/pph/x1dynarray1.cc (assembly comparison) Lawrence is reorganizing those tests as we spe

Re: [pph] Fix executable test detection (issue4635087)

2011-07-01 Thread Lawrence Crowl
LGTM On 7/1/11, Gabriel Charette wrote: > [string compare "dg-do-what" "run"] which was used before would always > return true. > > Thus the tests would no longer even get to the asm diff section... > > Me and Lawrence tried to find a way to get the content of the "dg-do-what" > variable, but cou

[pph] Fix executable test detection (issue4635087)

2011-07-01 Thread Gabriel Charette
[string compare "dg-do-what" "run"] which was used before would always return true. Thus the tests would no longer even get to the asm diff section... Me and Lawrence tried to find a way to get the content of the "dg-do-what" variable, but couldn't. We decided to revert to this quick hack fix