Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Uros Bizjak
On Fri, Feb 14, 2014 at 4:19 PM, Kai Tietz wrote: > Adjusted my original testcase so that eax isn't redeclared and > shadows. Additional moved > initialization of eax_live up. > ChangeLog > > 2014-02-14 Kai Tietz > > PR target/60193 > * config/i386/i386.c (ix86_expand_prologue): Use >

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Richard Henderson
On 02/14/2014 07:19 AM, Kai Tietz wrote: > 2014-02-14 Kai Tietz > > PR target/60193 > * config/i386/i386.c (ix86_expand_prologue): Use > rax register as displacement for restoring %r10, %rax. > Additional fix wrong offset for restoring both-registers. > > ChangeLog testsuite >

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Kai Tietz
2014-02-14 16:20 GMT+01:00 Richard Henderson : > On 02/14/2014 06:41 AM, Kai Tietz wrote: >> + else >> +{ >> + t = plus_constant (Pmode, eax, UNITS_PER_WORD); >> + emit_move_insn (eax, t); >> + t = gen_rtx_PLUS (Pmode, stack_pointer_rtx, eax); >> +} >

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Kai Tietz
Hi, Adjusted my original testcase so that eax isn't redeclared and shadows. Additional moved initialization of eax_live up. ChangeLog 2014-02-14 Kai Tietz PR target/60193 * config/i386/i386.c (ix86_expand_prologue): Use rax register as displacement for restoring %r10, %rax. A

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Richard Henderson
On 02/14/2014 06:41 AM, Kai Tietz wrote: > + else > +{ > + t = plus_constant (Pmode, eax, UNITS_PER_WORD); > + emit_move_insn (eax, t); > + t = gen_rtx_PLUS (Pmode, stack_pointer_rtx, eax); > +} Uros is right that you don't need the move here: 8(rsp,

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Uros Bizjak
On Fri, Feb 14, 2014 at 3:50 PM, Kai Tietz wrote: > 2014-02-14 15:40 GMT+01:00 Uros Bizjak : >> On Fri, Feb 14, 2014 at 2:48 PM, Kai Tietz wrote: >>> 2014-02-14 13:55 GMT+01:00 Uros Bizjak : Hello! > 2014-02-14 Kai Tietz > > PR target/60193 > * config/i386/i38

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Kai Tietz
2014-02-14 15:40 GMT+01:00 Uros Bizjak : > On Fri, Feb 14, 2014 at 2:48 PM, Kai Tietz wrote: >> 2014-02-14 13:55 GMT+01:00 Uros Bizjak : >>> Hello! >>> 2014-02-14 Kai Tietz PR target/60193 * config/i386/i386.c (ix86_expand_prologue): Use rax register as disp

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Kai Tietz
So, here is the asked more complex variant regarding displacement-value-range of amd64-instruction and taking care that we use constant-offsets instead of register-based displacement addressing if possible. ChangeLog 2014-02-14 Kai Tietz PR target/60193 * config/i386/i386.c (ix86_expa

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Uros Bizjak
On Fri, Feb 14, 2014 at 2:48 PM, Kai Tietz wrote: > 2014-02-14 13:55 GMT+01:00 Uros Bizjak : >> Hello! >> >>> 2014-02-14 Kai Tietz >>> >>> PR target/60193 >>> * config/i386/i386.c (ix86_expand_prologue): Use >>> rax register as displacement for restoring %r10, %eax. >>> >>> Regressi

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Kai Tietz
2014-02-14 13:55 GMT+01:00 Uros Bizjak : > Hello! > >> 2014-02-14 Kai Tietz >> >> PR target/60193 >> * config/i386/i386.c (ix86_expand_prologue): Use >> rax register as displacement for restoring %r10, %eax. >> >> Regression-tested for x86_64-unknown-linux-gnu, and >> x86_64-w64-ming

Re: [patch i386]: Fix PR/60193

2014-02-14 Thread Uros Bizjak
Hello! > 2014-02-14 Kai Tietz > > PR target/60193 > * config/i386/i386.c (ix86_expand_prologue): Use > rax register as displacement for restoring %r10, %eax. > > Regression-tested for x86_64-unknown-linux-gnu, and > x86_64-w64-mingw32, and i686-w64-mingw32. Ok for apply? No, you s

[patch i386]: Fix PR/60193

2014-02-14 Thread Kai Tietz
Hi, ChangeLog 2014-02-14 Kai Tietz PR target/60193 * config/i386/i386.c (ix86_expand_prologue): Use rax register as displacement for restoring %r10, %eax. Regression-tested for x86_64-unknown-linux-gnu, and x86_64-w64-mingw32, and i686-w64-mingw32. Ok for apply? Regards, Kai I