Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
On 8 November 2013 16:03, Jonathan Wakely wrote: > On 8 November 2013 15:41, Jonathan Wakely wrote: >> On 8 November 2013 14:51, Daniel Krügler wrote: >>> I have fully not grasped for which T the specializations of >>> __has_contiguous_iter are intended to be used, >> >> Currently, only std::contai

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
On 8 November 2013 15:41, Jonathan Wakely wrote: > On 8 November 2013 14:51, Daniel Krügler wrote: >> I have fully not grasped for which T the specializations of >> __has_contiguous_iter are intended to be used, > > Currently, only std::container iterators passed to a basic_regex > constructor, but

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
On 8 November 2013 14:51, Daniel Krügler wrote: > I have fully not grasped for which T the specializations of > __has_contiguous_iter are intended to be used, Currently, only std::container iterators passed to a basic_regex constructor, but in theory the trait could get moved to another header and

[patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
As I suggested yesterday on the libstdc++ list, this adds an overload for string and vector iterators to extract a raw pointer and re-use the _Compiler specialization, so that std::regex(".") and std::regex(std::string(".")) and std::regex(std::vector(1, '.')) only instantiate _Compiler once. 2013

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Daniel Krügler
2013/11/8 Jonathan Wakely : > As I suggested yesterday on the libstdc++ list, this adds an overload > for string and vector iterators to extract a raw pointer and re-use > the _Compiler specialization, so that std::regex(".") > and std::regex(std::string(".")) and std::regex(std::vector(1, > '.'))