Re: [patch 3/10] debug-early merge: C++ front-end

2015-05-20 Thread Jason Merrill
OK. Jason

Re: [patch 3/10] debug-early merge: C++ front-end

2015-05-20 Thread Aldy Hernandez
On 05/20/2015 03:18 PM, Jason Merrill wrote: On 05/08/2015 09:14 PM, Aldy Hernandez wrote: + if (!flag_syntax_only) +c_parse_final_cleanups (); The condition is a significant change of behavior for the C++ front end; doing final instantiation and such even with -fsyntax-only was a deliber

Re: [patch 3/10] debug-early merge: C++ front-end

2015-05-20 Thread Jason Merrill
On 05/08/2015 09:14 PM, Aldy Hernandez wrote: + if (!flag_syntax_only) +c_parse_final_cleanups (); The condition is a significant change of behavior for the C++ front end; doing final instantiation and such even with -fsyntax-only was a deliberate choice. Can we drop the condition? +

Re: [patch 3/10] debug-early merge: C++ front-end

2015-05-08 Thread Aldy Hernandez
On 05/08/2015 12:20 PM, Richard Biener wrote: Just meant that it's making the changes smaller if those bits can be checked in independently. If that's just a hassle... Well, who am I to look a gift horse in the mouth? Especially when you've volunteered to review most of this, and hopefully

Re: [patch 3/10] debug-early merge: C++ front-end

2015-05-08 Thread Richard Biener
On May 8, 2015 8:48:26 PM GMT+02:00, Aldy Hernandez wrote: >On 05/08/2015 04:57 AM, Richard Biener wrote: >> On Fri, May 8, 2015 at 2:34 AM, Aldy Hernandez >wrote: >>> >> >> Maybe you can split out the Java aliases stuff (that annoyed me >multiple times >> when trying to refactor the FE - middle-

Re: [patch 3/10] debug-early merge: C++ front-end

2015-05-08 Thread Aldy Hernandez
On 05/08/2015 04:57 AM, Richard Biener wrote: On Fri, May 8, 2015 at 2:34 AM, Aldy Hernandez wrote: Maybe you can split out the Java aliases stuff (that annoyed me multiple times when trying to refactor the FE - middle-end interface). It looks unrelated enough. Thanks, Richard. Jason al

Re: [patch 3/10] debug-early merge: C++ front-end

2015-05-08 Thread Richard Biener
On Fri, May 8, 2015 at 2:34 AM, Aldy Hernandez wrote: > Maybe you can split out the Java aliases stuff (that annoyed me multiple times when trying to refactor the FE - middle-end interface). It looks unrelated enough. Thanks, Richard.

[patch 3/10] debug-early merge: C++ front-end

2015-05-07 Thread Aldy Hernandez
gcc/cp/ * cp-objcp-common.c: Adjust comment for cxx_warn_unused_global_decl. * cp-objcp-common.h (LANG_HOOKS_WRITE_GLOBALS): Remove (LANG_HOOKS_POST_COMPILATION_PARSING_CLEANUPS): New. * cp-tree.h (note_mangling_alias): Protoize. (cp_write_global_declarations): Remove. (cxx_post_compilatio