Re: [patch 2/N] std::regex refactoring - sub _Executor for lookahead

On Mon, Apr 28, 2014 at 10:55 AM, Jonathan Wakely wrote: > Ah yes, I didn't think of that. But the size of _Executor is fixed, > isn't it? If it has a huge number of states or matches those will be > on the heap anyway, in vectors/arrays. > > It could be huge if instantiated with a huge iterator

Re: [patch 2/N] std::regex refactoring - sub _Executor for lookahead

On 28/04/14 10:18 -0400, Tim Shen wrote: On Mon, Apr 28, 2014 at 8:45 AM, Jonathan Wakely wrote: Is there any reason this object is created on the heap? Say, _Executor's size is so huge and a uncommon user gets a stack overflow by keep invoking this function? Ah yes, I didn't think of that.

Re: [patch 2/N] std::regex refactoring - sub _Executor for lookahead

On Mon, Apr 28, 2014 at 8:45 AM, Jonathan Wakely wrote: > Is there any reason this object is created on the heap? Say, _Executor's size is so huge and a uncommon user gets a stack overflow by keep invoking this function? -- Regards, Tim Shen

[patch 2/N] std::regex refactoring - sub _Executor for lookahead

Is there any reason this object is created on the heap? diff --git a/libstdc++-v3/include/bits/regex_executor.tcc b/libstdc++-v3/include/bits/regex_executor.tcc index 7f89933..92ca590 100644 --- a/libstdc++-v3/include/bits/regex_executor.tcc +++ b/libstdc++-v3/include/bits/regex_executor.tcc @@